From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions
Date: Thu, 08 Aug 2013 17:31:46 +0200 [thread overview]
Message-ID: <5203B9E2.8080808@siemens.com> (raw)
In-Reply-To: <CAFEAcA8QxbEjs8LHrudf5s5tn8LQuc-TMWRcHXhyvj2vpnxLsw@mail.gmail.com>
On 2013-08-08 17:13, Peter Maydell wrote:
> On 16 July 2013 13:45, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> This restore the behavior prior to b018ddf633 which accidentally changed
>> the return code to 0. Specifically guests probing for register existence
>> were affected by this.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> For the record (I know you have a revert-patch on the list)
> this patch breaks the 'musicpal' platform (my test image
> no longer boots with this change).
Yes, that's how I finally found out as well that this patch was wrong.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2013-08-08 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 12:45 [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions Jan Kiszka
2013-07-16 12:47 ` Paolo Bonzini
2013-07-17 2:00 ` Stefan Hajnoczi
2013-08-08 15:13 ` Peter Maydell
2013-08-08 15:31 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203B9E2.8080808@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.