All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
Cc: tony@atomide.com, benoit.cousson@linaro.org, rnayak@ti.com,
	peter.ujfalusi@ti.com, kishon@ti.com, jic23@cam.ac.uk,
	grant.likely@linaro.org, rob.herring@calxeda.com,
	lars@metafoo.de, sameo@linux.intel.com, ch.naveen@samsung.com,
	poeschel@lemonage.de, milo.kim@ti.com, balajitk@ti.com,
	gg@slimlogic.co.uk, linux-iio@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Tue, 16 Jul 2013 18:22:08 +0400	[thread overview]
Message-ID: <51E55710.8060907@cogentembedded.com> (raw)
In-Reply-To: <1373974500-23609-1-git-send-email-oleksandr.kozaruk@ti.com>

Hello.

On 07/16/2013 03:34 PM, Oleksandr Kozaruk wrote:

> GPADC is the general purpose ADC present on twl6030.
> The dt data is interrupt used to trigger end of ADC
> conversion.

> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
> ---
>   arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)

> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
> index 2e3bd31..434842c 100644
> --- a/arch/arm/boot/dts/twl6030.dtsi
> +++ b/arch/arm/boot/dts/twl6030.dtsi
> @@ -103,4 +103,10 @@
>   		compatible = "ti,twl6030-pwmled";
>   		#pwm-cells = <2>;
>   	};
> +
> +	gpadc: twl6030_gpadc {
> +		compatible = "ti,twl6030_gpadc";
> +		interrupts = <3>;
> +		#io-channel-cells = <1>;
> +	};

    ePAPR [1] says: "The name of a node should be somewhat generic, 
reflecting the function of the device and not its precise programming 
model."

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Oleksandr Kozaruk <oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	rnayak-l0cyMroinI0@public.gmane.org,
	peter.ujfalusi-l0cyMroinI0@public.gmane.org,
	kishon-l0cyMroinI0@public.gmane.org,
	jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org,
	milo.kim-l0cyMroinI0@public.gmane.org,
	balajitk-l0cyMroinI0@public.gmane.org,
	gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Tue, 16 Jul 2013 18:22:08 +0400	[thread overview]
Message-ID: <51E55710.8060907@cogentembedded.com> (raw)
In-Reply-To: <1373974500-23609-1-git-send-email-oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>

Hello.

On 07/16/2013 03:34 PM, Oleksandr Kozaruk wrote:

> GPADC is the general purpose ADC present on twl6030.
> The dt data is interrupt used to trigger end of ADC
> conversion.

> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
> ---
>   arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)

> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
> index 2e3bd31..434842c 100644
> --- a/arch/arm/boot/dts/twl6030.dtsi
> +++ b/arch/arm/boot/dts/twl6030.dtsi
> @@ -103,4 +103,10 @@
>   		compatible = "ti,twl6030-pwmled";
>   		#pwm-cells = <2>;
>   	};
> +
> +	gpadc: twl6030_gpadc {
> +		compatible = "ti,twl6030_gpadc";
> +		interrupts = <3>;
> +		#io-channel-cells = <1>;
> +	};

    ePAPR [1] says: "The name of a node should be somewhat generic, 
reflecting the function of the device and not its precise programming 
model."

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree
Date: Tue, 16 Jul 2013 18:22:08 +0400	[thread overview]
Message-ID: <51E55710.8060907@cogentembedded.com> (raw)
In-Reply-To: <1373974500-23609-1-git-send-email-oleksandr.kozaruk@ti.com>

Hello.

On 07/16/2013 03:34 PM, Oleksandr Kozaruk wrote:

> GPADC is the general purpose ADC present on twl6030.
> The dt data is interrupt used to trigger end of ADC
> conversion.

> Signed-off-by: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
> ---
>   arch/arm/boot/dts/twl6030.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)

> diff --git a/arch/arm/boot/dts/twl6030.dtsi b/arch/arm/boot/dts/twl6030.dtsi
> index 2e3bd31..434842c 100644
> --- a/arch/arm/boot/dts/twl6030.dtsi
> +++ b/arch/arm/boot/dts/twl6030.dtsi
> @@ -103,4 +103,10 @@
>   		compatible = "ti,twl6030-pwmled";
>   		#pwm-cells = <2>;
>   	};
> +
> +	gpadc: twl6030_gpadc {
> +		compatible = "ti,twl6030_gpadc";
> +		interrupts = <3>;
> +		#io-channel-cells = <1>;
> +	};

    ePAPR [1] says: "The name of a node should be somewhat generic, 
reflecting the function of the device and not its precise programming 
model."

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

  parent reply	other threads:[~2013-07-16 14:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 11:34 [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-16 11:34 ` Oleksandr Kozaruk
2013-07-16 11:34 ` Oleksandr Kozaruk
2013-07-16 11:35 ` [PATCH v4 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-16 11:35   ` Oleksandr Kozaruk
2013-07-16 11:35   ` Oleksandr Kozaruk
2013-07-16 14:22 ` Sergei Shtylyov [this message]
2013-07-16 14:22   ` [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree Sergei Shtylyov
2013-07-16 14:22   ` Sergei Shtylyov
  -- strict thread matches above, loose matches on Subject: below --
2013-07-16 11:47 [PATCH v4 0/2] TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-16 11:47 ` [PATCH v4 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-16 11:47   ` Oleksandr Kozaruk
2013-07-16 11:47   ` Oleksandr Kozaruk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E55710.8060907@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=balajitk@ti.com \
    --cc=benoit.cousson@linaro.org \
    --cc=ch.naveen@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=jic23@cam.ac.uk \
    --cc=kishon@ti.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=milo.kim@ti.com \
    --cc=oleksandr.kozaruk@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=poeschel@lemonage.de \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.