Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

On 07/15/2013 08:43 PM, Stefan Hajnoczi wrote:
> On Tue, Jul 09, 2013 at 03:30:13PM +0800, Qiao Nuohan wrote:
>>  if test "$seccomp" != "no" ; then
>> @@ -3872,6 +3914,14 @@ if test "$glx" = "yes" ; then
>>    echo "GLX_LIBS=$glx_libs" >> $config_host_mak
>>  fi
>>  
>> +if test "$lzo" = "yes" ; then
>> +  echo "CONFIG_LZO=y" >> $config_host_mak
>> +fi
>> +
>> +if test "$snappy" = "yes" ; then
>> +  echo "CONFIG_SNAPPY=y" >> $config_host_mak
>> +fi
> 
> Please also include a run-time check so QEMU can produce an error when a
> user chooses a compression algorithm which is not built in.  For
> example, the user should get a clear error when they select Snappy but
> QEMU was built without Snappy support.

Here's an instance where runtime introspection would come in handy -
knowing which values of an enum are actually supportable, vs. the entire
list of names but relying on decent errors for the elements that weren't
compiled in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]