Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

[Qiao Nuohan <qiaonuohan@cn.fujitsu.com>]

Thanks for your comments!


On 07/16/2013 10:43 AM, Stefan Hajnoczi wrote:
>> @@ -130,6 +139,13 @@ typedef struct DataCache {
>> >        off_t offset;       /* offset of the file */
>> >    } DataCache;
>> >
>> >  +typedef struct PageDesc {
>> >  +    off_t offset;                   /* the offset of the page data*/
> The guest may be 32-bit or 64-bit, independently of the QEMU host
> wordsize.  Is off_t correct when running a 64-bit guest on a 32-bit
> host?
>
> I guess you are assuming off_t == uint64_t here?
>

The 'offset' should be 64-bit in kdump format both on 32-bit and 64-bit. And I
will avoid using off_t in structure used by kdump format. Thanks for pointing
it out.

-- 
Regards
Qiao Nuohan