* [Qemu-trivial] [PATCH] linux-user: declare sys_futex to have 6 arguments
@ 2013-07-15 13:17 ` Petar Jovanovic
0 siblings, 0 replies; 6+ messages in thread
From: Petar Jovanovic @ 2013-07-15 13:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, riku.voipio, petar.jovanovic
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
declaration in the mips_syscall_args array.
This change fixes the cases where the 5th and 6th arguments have non-zero
value and have importance. An example is a Linux implementation of
pthread_cond_wait() function.
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 7f15d3d..99c3b3f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2028,7 +2028,7 @@ static const uint8_t mips_syscall_args[] = {
MIPS_SYS(sys_fremovexattr, 2) /* 4235 */
MIPS_SYS(sys_tkill , 2)
MIPS_SYS(sys_sendfile64 , 5)
- MIPS_SYS(sys_futex , 2)
+ MIPS_SYS(sys_futex , 6)
MIPS_SYS(sys_sched_setaffinity, 3)
MIPS_SYS(sys_sched_getaffinity, 3) /* 4240 */
MIPS_SYS(sys_io_setup , 2)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] linux-user: declare sys_futex to have 6 arguments
@ 2013-07-15 13:17 ` Petar Jovanovic
0 siblings, 0 replies; 6+ messages in thread
From: Petar Jovanovic @ 2013-07-15 13:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, riku.voipio, petar.jovanovic, aurelien
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
declaration in the mips_syscall_args array.
This change fixes the cases where the 5th and 6th arguments have non-zero
value and have importance. An example is a Linux implementation of
pthread_cond_wait() function.
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
---
linux-user/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 7f15d3d..99c3b3f 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2028,7 +2028,7 @@ static const uint8_t mips_syscall_args[] = {
MIPS_SYS(sys_fremovexattr, 2) /* 4235 */
MIPS_SYS(sys_tkill , 2)
MIPS_SYS(sys_sendfile64 , 5)
- MIPS_SYS(sys_futex , 2)
+ MIPS_SYS(sys_futex , 6)
MIPS_SYS(sys_sched_setaffinity, 3)
MIPS_SYS(sys_sched_getaffinity, 3) /* 4240 */
MIPS_SYS(sys_io_setup , 2)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user: declare sys_futex to have 6 arguments
2013-07-15 13:17 ` [Qemu-devel] " Petar Jovanovic
@ 2013-07-15 13:26 ` Peter Maydell
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2013-07-15 13:26 UTC (permalink / raw)
To: Petar Jovanovic; +Cc: qemu-trivial, riku.voipio, qemu-devel, petar.jovanovic
On 15 July 2013 14:17, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
> declaration in the mips_syscall_args array.
>
> This change fixes the cases where the 5th and 6th arguments have non-zero
> value and have importance. An example is a Linux implementation of
> pthread_cond_wait() function.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This is the QEMU version of a bug fixed in the Linux kernel
by commit 90a67b590 in 2005...
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: declare sys_futex to have 6 arguments
@ 2013-07-15 13:26 ` Peter Maydell
0 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2013-07-15 13:26 UTC (permalink / raw)
To: Petar Jovanovic
Cc: qemu-trivial, riku.voipio, qemu-devel, aurelien, petar.jovanovic
On 15 July 2013 14:17, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
> declaration in the mips_syscall_args array.
>
> This change fixes the cases where the 5th and 6th arguments have non-zero
> value and have importance. An example is a Linux implementation of
> pthread_cond_wait() function.
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This is the QEMU version of a bug fixed in the Linux kernel
by commit 90a67b590 in 2005...
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] linux-user: declare sys_futex to have 6 arguments
2013-07-15 13:17 ` [Qemu-devel] " Petar Jovanovic
@ 2013-07-16 17:54 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-07-16 17:54 UTC (permalink / raw)
To: Petar Jovanovic; +Cc: qemu-trivial, riku.voipio, qemu-devel, petar.jovanovic
15.07.2013 17:17, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
> declaration in the mips_syscall_args array.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: declare sys_futex to have 6 arguments
@ 2013-07-16 17:54 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2013-07-16 17:54 UTC (permalink / raw)
To: Petar Jovanovic; +Cc: qemu-trivial, riku.voipio, qemu-devel, petar.jovanovic
15.07.2013 17:17, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> sys_futex has 6 arguments, and all of these need to be copied. Fix incorrect
> declaration in the mips_syscall_args array.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-16 17:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 13:17 [Qemu-trivial] [PATCH] linux-user: declare sys_futex to have 6 arguments Petar Jovanovic
2013-07-15 13:17 ` [Qemu-devel] " Petar Jovanovic
2013-07-15 13:26 ` [Qemu-trivial] " Peter Maydell
2013-07-15 13:26 ` Peter Maydell
2013-07-16 17:54 ` [Qemu-trivial] " Michael Tokarev
2013-07-16 17:54 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.