From: Wei Ni <wni@nvidia.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit
Date: Wed, 17 Jul 2013 15:09:43 +0800 [thread overview]
Message-ID: <51E64337.6040004@nvidia.com> (raw)
In-Reply-To: <51E641C7.4000107@nvidia.com>
On 07/17/2013 03:03 PM, Wei Ni wrote:
> On 07/16/2013 12:57 AM, Jean Delvare wrote:
>> Hi Wei, Guenter,
>>
>>> +
>>> + if ((status & 0x7f) == 0 && (status2 & 0xfe) == 0)
>>> + return false;
>>
>> It's a bit disappointing to not use the freshly introduced constants.
>> That being said I agree it would make the code hard to read, so you can
>> leave it as is.
>
> Sorry, I forgot it.
> How about to define:
> #define LM90_STATUS_MASK 0x7f
> #define MAX6696_STATUS2 0xfe
Sorry, it should be "#define MAX6696_STATUS2_MASK 0xfe".
>
> Or since Guenter is for vacation, I can just leave it as is, and wait
> him back to talk about below issue.
>
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: Wei Ni <wni@nvidia.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit
Date: Wed, 17 Jul 2013 07:09:43 +0000 [thread overview]
Message-ID: <51E64337.6040004@nvidia.com> (raw)
In-Reply-To: <51E641C7.4000107@nvidia.com>
On 07/17/2013 03:03 PM, Wei Ni wrote:
> On 07/16/2013 12:57 AM, Jean Delvare wrote:
>> Hi Wei, Guenter,
>>
>>> +
>>> + if ((status & 0x7f) = 0 && (status2 & 0xfe) = 0)
>>> + return false;
>>
>> It's a bit disappointing to not use the freshly introduced constants.
>> That being said I agree it would make the code hard to read, so you can
>> leave it as is.
>
> Sorry, I forgot it.
> How about to define:
> #define LM90_STATUS_MASK 0x7f
> #define MAX6696_STATUS2 0xfe
Sorry, it should be "#define MAX6696_STATUS2_MASK 0xfe".
>
> Or since Guenter is for vacation, I can just leave it as is, and wait
> him back to talk about below issue.
>
>>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-07-17 7:09 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 7:48 [PATCH v3 0/4] Lm90 Enhancements Wei Ni
2013-07-12 7:48 ` Wei Ni
2013-07-12 7:48 ` [lm-sensors] " Wei Ni
2013-07-12 7:48 ` [PATCH v3 1/4] hwmon: (lm90) split set&show temp as common codes Wei Ni
2013-07-12 7:48 ` Wei Ni
2013-07-12 7:48 ` [lm-sensors] " Wei Ni
[not found] ` <1373615287-18502-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-12 13:26 ` Jean Delvare
2013-07-12 13:26 ` Jean Delvare
2013-07-12 13:26 ` [lm-sensors] " Jean Delvare
[not found] ` <20130712152615.23464a6b-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-12 13:50 ` Guenter Roeck
2013-07-12 13:50 ` Guenter Roeck
2013-07-12 13:50 ` [lm-sensors] " Guenter Roeck
[not found] ` <20130712135000.GA3386-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-07-12 14:30 ` Jean Delvare
2013-07-12 14:30 ` Jean Delvare
2013-07-12 14:30 ` [lm-sensors] " Jean Delvare
2013-07-12 14:40 ` Guenter Roeck
2013-07-12 14:40 ` [lm-sensors] " Guenter Roeck
2013-07-15 6:25 ` Wei Ni
2013-07-15 6:25 ` Wei Ni
2013-07-15 6:25 ` [lm-sensors] " Wei Ni
2013-07-15 7:24 ` Jean Delvare
2013-07-15 7:24 ` Jean Delvare
2013-07-15 7:24 ` [lm-sensors] " Jean Delvare
[not found] ` <20130715092415.6d082aa2-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-15 9:14 ` Wei Ni
2013-07-15 9:14 ` Wei Ni
2013-07-15 9:14 ` [lm-sensors] " Wei Ni
[not found] ` <51E3BD5F.6060806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-15 17:52 ` Jean Delvare
2013-07-15 17:52 ` Jean Delvare
2013-07-15 17:52 ` [lm-sensors] " Jean Delvare
2013-07-17 4:26 ` Thierry Reding
2013-07-17 4:26 ` [lm-sensors] " Thierry Reding
2013-07-17 5:14 ` Guenter Roeck
2013-07-17 5:14 ` [lm-sensors] " Guenter Roeck
2013-07-17 6:26 ` Wei Ni
2013-07-17 6:26 ` [lm-sensors] " Wei Ni
2013-07-17 9:11 ` Jean Delvare
2013-07-17 9:11 ` [lm-sensors] " Jean Delvare
2013-07-17 9:54 ` Wei Ni
2013-07-17 9:54 ` [lm-sensors] " Wei Ni
2013-07-15 6:05 ` Wei Ni
2013-07-15 6:05 ` Wei Ni
2013-07-15 6:05 ` [lm-sensors] " Wei Ni
[not found] ` <51E39114.505-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-15 7:29 ` Jean Delvare
2013-07-15 7:29 ` Jean Delvare
2013-07-15 7:29 ` [lm-sensors] " Jean Delvare
[not found] ` <1373615287-18502-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-12 7:48 ` [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit Wei Ni
2013-07-12 7:48 ` Wei Ni
2013-07-12 7:48 ` [lm-sensors] " Wei Ni
2013-07-15 16:57 ` Jean Delvare
2013-07-15 16:57 ` Jean Delvare
2013-07-15 16:57 ` [lm-sensors] " Jean Delvare
[not found] ` <20130715185727.4ebde8c4-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-15 17:33 ` Guenter Roeck
2013-07-15 17:33 ` Guenter Roeck
2013-07-15 17:33 ` [lm-sensors] " Guenter Roeck
[not found] ` <20130715173322.GA20484-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-10-30 15:33 ` Jean Delvare
2013-10-30 15:33 ` Jean Delvare
2013-10-30 15:33 ` [lm-sensors] " Jean Delvare
[not found] ` <20131030163326.4e7e0cfc-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-10-30 16:11 ` Guenter Roeck
2013-10-30 16:11 ` Guenter Roeck
2013-10-30 16:11 ` [lm-sensors] " Guenter Roeck
2013-10-30 16:56 ` Guenter Roeck
2013-10-30 16:56 ` Guenter Roeck
2013-10-30 16:56 ` [lm-sensors] " Guenter Roeck
2013-07-17 7:03 ` Wei Ni
2013-07-17 7:03 ` Wei Ni
2013-07-17 7:03 ` [lm-sensors] " Wei Ni
2013-07-17 7:09 ` Wei Ni [this message]
2013-07-17 7:09 ` Wei Ni
[not found] ` <51E641C7.4000107-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17 8:28 ` Jean Delvare
2013-07-17 8:28 ` Jean Delvare
2013-07-17 8:28 ` [lm-sensors] " Jean Delvare
2013-07-17 9:29 ` Wei Ni
2013-07-17 9:29 ` [lm-sensors] " Wei Ni
[not found] ` <51E663FC.5050209-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17 9:46 ` Jean Delvare
2013-07-17 9:46 ` Jean Delvare
2013-07-17 9:46 ` [lm-sensors] " Jean Delvare
2013-07-12 7:48 ` [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ Wei Ni
2013-07-12 7:48 ` Wei Ni
2013-07-12 7:48 ` [lm-sensors] " Wei Ni
2013-07-18 15:58 ` Jean Delvare
2013-07-18 15:58 ` Jean Delvare
2013-07-18 15:58 ` [lm-sensors] " Jean Delvare
[not found] ` <20130718175822.62c358bf-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-19 6:41 ` Wei Ni
2013-07-19 6:41 ` Wei Ni
2013-07-19 6:41 ` [lm-sensors] " Wei Ni
[not found] ` <51E8DFB2.9070701-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-24 7:46 ` Wei Ni
2013-07-24 7:46 ` Wei Ni
2013-07-24 7:46 ` [lm-sensors] " Wei Ni
2013-07-24 8:08 ` Jean Delvare
2013-07-24 8:08 ` [lm-sensors] " Jean Delvare
2013-07-27 15:02 ` Jean Delvare
2013-07-27 15:02 ` [lm-sensors] " Jean Delvare
2013-07-29 10:14 ` Wei Ni
2013-07-29 10:14 ` [lm-sensors] " Wei Ni
[not found] ` <51F640A0.4040809-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-29 15:58 ` Jean Delvare
2013-07-29 15:58 ` Jean Delvare
2013-07-29 15:58 ` [lm-sensors] " Jean Delvare
[not found] ` <20130729175835.795dba2b-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-30 8:18 ` Wei Ni
2013-07-30 8:18 ` Wei Ni
2013-07-30 8:18 ` [lm-sensors] " Wei Ni
[not found] ` <51F776DB.3060104-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-16 12:34 ` Jean Delvare
2013-09-16 12:34 ` Jean Delvare
2013-09-16 12:34 ` [lm-sensors] " Jean Delvare
2013-07-12 7:48 ` [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11 Wei Ni
2013-07-12 7:48 ` Wei Ni
2013-07-12 7:48 ` [lm-sensors] " Wei Ni
[not found] ` <1373615287-18502-5-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-27 15:38 ` Jean Delvare
2013-07-27 15:38 ` Jean Delvare
2013-07-27 15:38 ` [lm-sensors] " Jean Delvare
[not found] ` <20130727173830.14cb5b21-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-29 11:15 ` Wei Ni
2013-07-29 11:15 ` Wei Ni
2013-07-29 11:15 ` [lm-sensors] " Wei Ni
[not found] ` <51F64EC0.800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-29 15:48 ` Jean Delvare
2013-07-29 15:48 ` Jean Delvare
2013-07-29 15:48 ` [lm-sensors] " Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E64337.6040004@nvidia.com \
--to=wni@nvidia.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.