From: Oleksandr Kozaruk <oleksandr.kozaruk@ti.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: <tony@atomide.com>, <benoit.cousson@linaro.org>, <rnayak@ti.com>,
<peter.ujfalusi@ti.com>, <kishon@ti.com>, <jic23@cam.ac.uk>,
<grant.likely@linaro.org>, <rob.herring@calxeda.com>,
<lars@metafoo.de>, <sameo@linux.intel.com>,
<ch.naveen@samsung.com>, <poeschel@lemonage.de>,
<milo.kim@ti.com>, <balajitk@ti.com>, <gg@slimlogic.co.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Date: Wed, 17 Jul 2013 12:49:40 +0300 [thread overview]
Message-ID: <51E668B4.1010000@ti.com> (raw)
In-Reply-To: <c8f86766-822b-4fe3-ae2a-e0b12412ef39@email.android.com>
Hello Jonathan,
>Two very quick comments based on quick glance as it may be a while
before I can do a full review.
>We still have channels that are only usable for temperature being
output to user space as voltage channels? Is the conversion so very hard?
Can you please clarify what should return temperature channel for
in_tempX_input (processed)? Is it voltage or Celsius degree?
in_tempX_raw should return ADC code? Right?
Regards,
OK.
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr Kozaruk <oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
rnayak-l0cyMroinI0@public.gmane.org,
peter.ujfalusi-l0cyMroinI0@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org,
milo.kim-l0cyMroinI0@public.gmane.org,
balajitk-l0cyMroinI0@public.gmane.org,
gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Date: Wed, 17 Jul 2013 12:49:40 +0300 [thread overview]
Message-ID: <51E668B4.1010000@ti.com> (raw)
In-Reply-To: <c8f86766-822b-4fe3-ae2a-e0b12412ef39-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
Hello Jonathan,
>Two very quick comments based on quick glance as it may be a while
before I can do a full review.
>We still have channels that are only usable for temperature being
output to user space as voltage channels? Is the conversion so very hard?
Can you please clarify what should return temperature channel for
in_tempX_input (processed)? Is it voltage or Celsius degree?
in_tempX_raw should return ADC code? Right?
Regards,
OK.
WARNING: multiple messages have this Message-ID (diff)
From: oleksandr.kozaruk@ti.com (Oleksandr Kozaruk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Date: Wed, 17 Jul 2013 12:49:40 +0300 [thread overview]
Message-ID: <51E668B4.1010000@ti.com> (raw)
In-Reply-To: <c8f86766-822b-4fe3-ae2a-e0b12412ef39@email.android.com>
Hello Jonathan,
>Two very quick comments based on quick glance as it may be a while
before I can do a full review.
>We still have channels that are only usable for temperature being
output to user space as voltage channels? Is the conversion so very hard?
Can you please clarify what should return temperature channel for
in_tempX_input (processed)? Is it voltage or Celsius degree?
in_tempX_raw should return ADC code? Right?
Regards,
OK.
next prev parent reply other threads:[~2013-07-17 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 11:27 [PATCH v4 0/2] TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
2013-07-16 11:27 ` [PATCH 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
2013-07-16 11:27 ` [PATCH 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
2013-07-16 11:27 ` Oleksandr Kozaruk
[not found] ` <1373974023-23521-3-git-send-email-oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
2013-07-16 16:28 ` Jonathan Cameron
2013-07-17 9:49 ` Oleksandr Kozaruk [this message]
2013-07-17 9:49 ` Oleksandr Kozaruk
2013-07-17 9:49 ` Oleksandr Kozaruk
2013-07-17 19:04 ` Jonathan Cameron
2013-07-17 19:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E668B4.1010000@ti.com \
--to=oleksandr.kozaruk@ti.com \
--cc=balajitk@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=kishon@ti.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=poeschel@lemonage.de \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.