From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
Stephen Warren <swarren@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: tegra: depend on ARCH_TEGRA, not ARCH_TEGRA_*
Date: Wed, 17 Jul 2013 12:23:03 -0600 [thread overview]
Message-ID: <51E6E107.8020300@wwwdotorg.org> (raw)
In-Reply-To: <20130717175701.GY22506@sirena.org.uk>
On 07/17/2013 11:57 AM, Mark Brown wrote:
> On Wed, Jul 17, 2013 at 11:01:30AM -0600, Stephen Warren wrote:
>> On 07/17/2013 02:30 AM, Mark Brown wrote:
>
>> - select SND_SOC_TEGRA20_I2S if ARCH_TEGRA_2x_SOC -
>> select SND_SOC_TEGRA30_I2S if ARCH_TEGRA_3x_SOC + select
>> SND_SOC_TEGRA20_I2S + select SND_SOC_TEGRA30_I2S
>
>> But then, it won't be possible to disable support for older
>> SoCs, since simply enabling a machine driver that might support
>> Tegra20 would force ASoC support for Tegra20 to be enabled, even
>> if the user only cares about Tegra30.
>
> So how do they disable the core support for the older SoCs with the
> new model?
They don't; the core support is so small it's not worth having the
ifdefs in it; just a few K. As such, it seems simpler to just always
compile in the core support, and remove the need for all the ifdef
nests in mach-tegra/. The bulk of the differences are different
drivers for different chips.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: tegra: depend on ARCH_TEGRA, not ARCH_TEGRA_*
Date: Wed, 17 Jul 2013 12:23:03 -0600 [thread overview]
Message-ID: <51E6E107.8020300@wwwdotorg.org> (raw)
In-Reply-To: <20130717175701.GY22506@sirena.org.uk>
On 07/17/2013 11:57 AM, Mark Brown wrote:
> On Wed, Jul 17, 2013 at 11:01:30AM -0600, Stephen Warren wrote:
>> On 07/17/2013 02:30 AM, Mark Brown wrote:
>
>> - select SND_SOC_TEGRA20_I2S if ARCH_TEGRA_2x_SOC -
>> select SND_SOC_TEGRA30_I2S if ARCH_TEGRA_3x_SOC + select
>> SND_SOC_TEGRA20_I2S + select SND_SOC_TEGRA30_I2S
>
>> But then, it won't be possible to disable support for older
>> SoCs, since simply enabling a machine driver that might support
>> Tegra20 would force ASoC support for Tegra20 to be enabled, even
>> if the user only cares about Tegra30.
>
> So how do they disable the core support for the older SoCs with the
> new model?
They don't; the core support is so small it's not worth having the
ifdefs in it; just a few K. As such, it seems simpler to just always
compile in the core support, and remove the need for all the ifdef
nests in mach-tegra/. The bulk of the differences are different
drivers for different chips.
next prev parent reply other threads:[~2013-07-17 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 22:27 [PATCH] ASoC: tegra: depend on ARCH_TEGRA, not ARCH_TEGRA_* Stephen Warren
2013-07-16 22:27 ` Stephen Warren
[not found] ` <1374013667-21435-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-17 8:30 ` Mark Brown
2013-07-17 8:30 ` Mark Brown
[not found] ` <20130717083003.GA22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-17 17:01 ` Stephen Warren
2013-07-17 17:01 ` Stephen Warren
2013-07-17 17:57 ` Mark Brown
2013-07-17 17:57 ` Mark Brown
2013-07-17 18:23 ` Stephen Warren [this message]
2013-07-17 18:23 ` Stephen Warren
[not found] ` <51E6E107.8020300-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-17 22:33 ` Mark Brown
2013-07-17 22:33 ` Mark Brown
[not found] ` <20130717223309.GZ22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-17 22:52 ` Stephen Warren
2013-07-17 22:52 ` Stephen Warren
[not found] ` <51E7203A.2020007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-18 9:58 ` Mark Brown
2013-07-18 9:58 ` Mark Brown
[not found] ` <20130718095815.GE22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-18 16:58 ` Stephen Warren
2013-07-18 16:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6E107.8020300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.