All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw
Date: Wed, 17 Jul 2013 21:56:45 +0200	[thread overview]
Message-ID: <51E6F6FD.5060208@redhat.com> (raw)
In-Reply-To: <51E6F046.6060900@twiddle.net>

Il 17/07/2013 21:28, Richard Henderson ha scritto:
> On 07/17/2013 11:57 AM, Paolo Bonzini wrote:
>> I'm still not sure what the bug is (so what the FIXME comment would
>> be)... except of course that there may be bug in access_with_adjusted_size.
> 
> The code here in exec.c is not using access_with_adjusted_size.

It is:

cpu_outb
-> address_space_write
-> address_space_rw
-> io_mem_write
-> memory_region_dispatch_write
-> access_with_adjusted_size

memory_access_size is just returning a length that makes sense when
passed to io_mem_write and ultimately to access_with_adjusted_size.

Paolo

> Unfortunately, access_with_adjusted_size only handles single copies,
> one direction at a time.  We're attempting a sort of "memcpy", which
> calls for some amount of caching across the loop...
> 
> 
> r~
> 

  reply	other threads:[~2013-07-17 19:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14 22:16 [Qemu-devel] [PULL 0/5] alpha-softmmu fixes Richard Henderson
2013-07-14 22:16 ` [Qemu-devel] [PULL 1/5] hw/alpha: Don't use get_system_io Richard Henderson
2013-07-14 22:16 ` [Qemu-devel] [PULL 2/5] hw/alpha: Don't machine check on missing pci i/o Richard Henderson
2013-07-14 22:16 ` [Qemu-devel] [PULL 3/5] exec: Support 64-bit operations in address_space_rw Richard Henderson
2013-07-17  9:50   ` Markus Armbruster
2013-07-17 11:09     ` Paolo Bonzini
2013-07-17 13:23       ` Richard Henderson
2013-07-17 13:45         ` Paolo Bonzini
2013-07-17 14:29           ` Richard Henderson
2013-07-17 14:41             ` Paolo Bonzini
2013-07-17 15:50       ` Anthony Liguori
2013-07-17 17:32         ` Paolo Bonzini
2013-07-17 18:26           ` Richard Henderson
2013-07-17 18:57             ` Paolo Bonzini
2013-07-17 19:28               ` Richard Henderson
2013-07-17 19:56                 ` Paolo Bonzini [this message]
2013-07-17 20:05                   ` Richard Henderson
2013-07-17 18:28           ` Anthony Liguori
2013-07-14 22:16 ` [Qemu-devel] [PULL 4/5] hw/alpha: Drop latch_tmp hack Richard Henderson
2013-07-14 22:16 ` [Qemu-devel] [PULL 5/5] hw/alpha: Use SRM epoch Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E6F6FD.5060208@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.