From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices
Date: Thu, 18 Jul 2013 07:02:11 -0600 [thread overview]
Message-ID: <51E7E753.3080605@redhat.com> (raw)
In-Reply-To: <20130718125548.GL3582@dhcp-200-207.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On 07/18/2013 06:55 AM, Kevin Wolf wrote:
> Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben:
>> Even if the VM is already stopped, we cannot assume that all data has
>> already been successfully flushed to disk. The flush during the previous
>> vm_stop() could have failed.
>>
>> Run bdrv_flush_all() unconditionally so that we get an error each time
>> if the block device isn't really flushed.
>>
>
> Oops, forgot it again:
>
> Cc: qemu-stable@nongnu.org
>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> cpus.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-18 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 12:52 [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices Kevin Wolf
2013-07-18 12:55 ` Kevin Wolf
2013-07-18 13:02 ` Eric Blake [this message]
2013-07-19 4:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E7E753.3080605@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.