From: Stephen Warren <swarren@wwwdotorg.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Boris BREZILLON <linux-arm@overkiz.com>,
Shawn Guo <shawn.guo@linaro.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Tomasz Figa <t.figa@samsung.com>
Subject: Re: [PATCH v2 0/4] Add PWM polarity flag macro for DT
Date: Thu, 18 Jul 2013 10:55:56 -0600 [thread overview]
Message-ID: <51E81E1C.20708@wwwdotorg.org> (raw)
In-Reply-To: <1374101664-21112-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 07/17/2013 04:54 PM, Laurent Pinchart wrote:
> Hello,
>
> Here's a small patch set that replaces PWM polarity numerical constants with
> macros in DT.
The series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
I'm (very very) slightly hesitant about patch 3/4, since it's moving
towards all PWMs having to use the same specifier format, whereas
specifiers are at least potentially binding-specific, not
device-type-specific. However, consistency is good; there's no need to
do something different just for the heck of it. Equally, there's nothing
actually stopping a new binding from defining its own format rather than
simply deferring to pwm.txt if it absolutely has to, so I think this
will turn out fine.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] Add PWM polarity flag macro for DT
Date: Thu, 18 Jul 2013 10:55:56 -0600 [thread overview]
Message-ID: <51E81E1C.20708@wwwdotorg.org> (raw)
In-Reply-To: <1374101664-21112-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 07/17/2013 04:54 PM, Laurent Pinchart wrote:
> Hello,
>
> Here's a small patch set that replaces PWM polarity numerical constants with
> macros in DT.
The series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
I'm (very very) slightly hesitant about patch 3/4, since it's moving
towards all PWMs having to use the same specifier format, whereas
specifiers are at least potentially binding-specific, not
device-type-specific. However, consistency is good; there's no need to
do something different just for the heck of it. Equally, there's nothing
actually stopping a new binding from defining its own format rather than
simply deferring to pwm.txt if it absolutely has to, so I think this
will turn out fine.
next prev parent reply other threads:[~2013-07-18 16:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 22:54 [PATCH v2 0/4] Add PWM polarity flag macro for DT Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-17 22:54 ` [PATCH v2 1/4] pwm: " Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-17 22:54 ` [PATCH v2 2/4] pwm: Use the DT macro directly when parsing PWM DT flags Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
[not found] ` <1374101664-21112-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-07-17 22:54 ` [PATCH v2 3/4] pwm: Update DT bindings to reference pwm.txt for cells documentation Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-17 22:54 ` [PATCH v2 4/4] ARM: dts: Use the PWM polarity flags Laurent Pinchart
2013-07-17 22:54 ` Laurent Pinchart
2013-07-18 16:55 ` Stephen Warren [this message]
2013-07-18 16:55 ` [PATCH v2 0/4] Add PWM polarity flag macro for DT Stephen Warren
2013-07-19 11:29 ` Laurent Pinchart
2013-07-19 11:29 ` Laurent Pinchart
2013-07-23 15:37 ` Thierry Reding
2013-07-23 15:37 ` Thierry Reding
2013-07-29 12:30 ` Thierry Reding
2013-07-29 12:30 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E81E1C.20708@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm@overkiz.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=t.figa@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.