All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1
@ 2013-07-15  8:21 Aaro Koskinen
  2013-07-15  9:55 ` Jayachandran C.
  2013-07-18 17:19 ` David Daney
  0 siblings, 2 replies; 3+ messages in thread
From: Aaro Koskinen @ 2013-07-15  8:21 UTC (permalink / raw)
  To: Ralf Baechle, Jayachandran C, linux-mips; +Cc: Aaro Koskinen

Commit 6ba045f9fbdafb48da42aa8576ea7a3980443136 (MIPS: Move generated code
to .text for microMIPS) deleted tlbmiss_handler_setup_pgd_array, but some
references were not converted. Fix that to enable building a MIPS kernel.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 arch/mips/mm/tlbex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index 9ab0f90..cc34521 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -1466,7 +1466,7 @@ static void __cpuinit build_r4000_setup_pgd(void)
 {
 	const int a0 = 4;
 	const int a1 = 5;
-	u32 *p = tlbmiss_handler_setup_pgd_array;
+	u32 *p = tlbmiss_handler_setup_pgd;
 	const int tlbmiss_handler_setup_pgd_size =
 		tlbmiss_handler_setup_pgd_end - tlbmiss_handler_setup_pgd;
 	struct uasm_label *l = labels;
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1
  2013-07-15  8:21 [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1 Aaro Koskinen
@ 2013-07-15  9:55 ` Jayachandran C.
  2013-07-18 17:19 ` David Daney
  1 sibling, 0 replies; 3+ messages in thread
From: Jayachandran C. @ 2013-07-15  9:55 UTC (permalink / raw)
  To: Aaro Koskinen; +Cc: Ralf Baechle, linux-mips

On Mon, Jul 15, 2013 at 11:21:57AM +0300, Aaro Koskinen wrote:
> Commit 6ba045f9fbdafb48da42aa8576ea7a3980443136 (MIPS: Move generated code
> to .text for microMIPS) deleted tlbmiss_handler_setup_pgd_array, but some
> references were not converted. Fix that to enable building a MIPS kernel.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>  arch/mips/mm/tlbex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..cc34521 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1466,7 +1466,7 @@ static void __cpuinit build_r4000_setup_pgd(void)
>  {
>  	const int a0 = 4;
>  	const int a1 = 5;
> -	u32 *p = tlbmiss_handler_setup_pgd_array;
> +	u32 *p = tlbmiss_handler_setup_pgd;
>  	const int tlbmiss_handler_setup_pgd_size =
>  		tlbmiss_handler_setup_pgd_end - tlbmiss_handler_setup_pgd;
>  	struct uasm_label *l = labels;

Acked-by: "Jayachandran C." <jchandra@broadcom.com>

Thanks, looks like I made a mistake splitting the patchset, this part went
into the next patch which didn't make it to 3.11.

JC.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1
  2013-07-15  8:21 [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1 Aaro Koskinen
  2013-07-15  9:55 ` Jayachandran C.
@ 2013-07-18 17:19 ` David Daney
  1 sibling, 0 replies; 3+ messages in thread
From: David Daney @ 2013-07-18 17:19 UTC (permalink / raw)
  To: Aaro Koskinen, Ralf Baechle; +Cc: Jayachandran C, linux-mips

On 07/15/2013 01:21 AM, Aaro Koskinen wrote:
> Commit 6ba045f9fbdafb48da42aa8576ea7a3980443136 (MIPS: Move generated code
> to .text for microMIPS) deleted tlbmiss_handler_setup_pgd_array, but some
> references were not converted. Fix that to enable building a MIPS kernel.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Yes, this appears to be needed.

Acked-by: David Daney <david.daney@cavium.com>


> ---
>   arch/mips/mm/tlbex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..cc34521 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1466,7 +1466,7 @@ static void __cpuinit build_r4000_setup_pgd(void)
>   {
>   	const int a0 = 4;
>   	const int a1 = 5;
> -	u32 *p = tlbmiss_handler_setup_pgd_array;
> +	u32 *p = tlbmiss_handler_setup_pgd;
>   	const int tlbmiss_handler_setup_pgd_size =
>   		tlbmiss_handler_setup_pgd_end - tlbmiss_handler_setup_pgd;
>   	struct uasm_label *l = labels;
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-07-18 17:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15  8:21 [PATCH] MIPS: tlbex: fix broken build in v3.11-rc1 Aaro Koskinen
2013-07-15  9:55 ` Jayachandran C.
2013-07-18 17:19 ` David Daney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.