All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RESEND][PATCH] mm: vmstats: tlb flush counters
Date: Fri, 19 Jul 2013 08:51:57 -0700	[thread overview]
Message-ID: <51E9609D.4030201@sr71.net> (raw)
In-Reply-To: <20130719082848.GA25784@gmail.com>

On 07/19/2013 01:28 AM, Ingo Molnar wrote:
> UP is slowly going extinct, but in any case these counters ought to inform 
> us about TLB flushes even on UP systems:
> 
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ALL,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE_KERNEL,
> While these ought to be compiled out on UP kernels:
> 
>>>> > > > +		NR_TLB_REMOTE_FLUSH,	/* cpu tried to flush others' tlbs */
>>>> > > > +		NR_TLB_REMOTE_FLUSH_RECEIVED,/* cpu received ipi for flush */
> Right?

Yeah, it's useful on UP too.  But I realized that my changes were
confined to the SMP code.  The UP code is almost all in one of the
headers, and I didn't touch it.  So I've got some work there to fix it up.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RESEND][PATCH] mm: vmstats: tlb flush counters
Date: Fri, 19 Jul 2013 08:51:57 -0700	[thread overview]
Message-ID: <51E9609D.4030201@sr71.net> (raw)
In-Reply-To: <20130719082848.GA25784@gmail.com>

On 07/19/2013 01:28 AM, Ingo Molnar wrote:
> UP is slowly going extinct, but in any case these counters ought to inform 
> us about TLB flushes even on UP systems:
> 
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ALL,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE,
>>>> > > > +		NR_TLB_LOCAL_FLUSH_ONE_KERNEL,
> While these ought to be compiled out on UP kernels:
> 
>>>> > > > +		NR_TLB_REMOTE_FLUSH,	/* cpu tried to flush others' tlbs */
>>>> > > > +		NR_TLB_REMOTE_FLUSH_RECEIVED,/* cpu received ipi for flush */
> Right?

Yeah, it's useful on UP too.  But I realized that my changes were
confined to the SMP code.  The UP code is almost all in one of the
headers, and I didn't touch it.  So I've got some work there to fix it up.


  reply	other threads:[~2013-07-19 15:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 23:44 [RESEND][PATCH] mm: vmstats: tlb flush counters Dave Hansen
2013-07-16 23:44 ` Dave Hansen
2013-07-17  7:21 ` Ingo Molnar
2013-07-17  7:21   ` Ingo Molnar
2013-07-18 20:51   ` Andrew Morton
2013-07-18 20:51     ` Andrew Morton
2013-07-19  8:28     ` Ingo Molnar
2013-07-19  8:28       ` Ingo Molnar
2013-07-19 15:51       ` Dave Hansen [this message]
2013-07-19 15:51         ` Dave Hansen
2013-07-19 11:38 ` Raghavendra KT
2013-07-19 11:38   ` Raghavendra KT
2013-07-19 15:20   ` Dave Hansen
2013-07-19 15:20     ` Dave Hansen
2013-07-20 13:09     ` Raghavendra K T
2013-07-20 13:09       ` Raghavendra K T
2013-07-22 10:06     ` Ingo Molnar
2013-07-22 10:06       ` Ingo Molnar
2013-07-22 16:59       ` Dave Hansen
2013-07-22 16:59         ` Dave Hansen
2013-07-23  8:17         ` Ingo Molnar
2013-07-23  8:17           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E9609D.4030201@sr71.net \
    --to=dave@sr71.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.