All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hector Palacios <hector.palacios@digi.com>
To: Marek Vasut <marex@denx.de>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"alexandre.belloni@free-electrons.com"
	<alexandre.belloni@free-electrons.com>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"fabio.estevam@freescale.com" <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale
Date: Fri, 19 Jul 2013 18:22:48 +0200	[thread overview]
Message-ID: <51E967D8.8020001@digi.com> (raw)
In-Reply-To: <201307191817.27102.marex@denx.de>

Dear Marek,

On 07/19/2013 06:17 PM, Marek Vasut wrote:
>> Here you have three entries per channel:
>> in_voltageX_raw		-> the sample raw value
>> in_voltageX_scale	-> the scale to multiply the raw value to get the
> voltage
>> in mV in_voltageX_scale_available -> lists the available scales of the
>> channel
>>
>> For example for channel 0:
>>
>> # cat in_voltage0_scale_available
>> 0.451660156 0.903320312	(two scales available, first with divider by two
>> disabled, second with divider by two enabled)
>>
>> # cat in_voltage0_scale
>> 0.451660156			(divider by two is currently disabled)
>>
>> # cat in_voltage0_raw		(shows measured value)
>> 1000
>>
>> If you multiply the value by the scale you get: 1000 * 0.451660156 = 451.6
>> mV
>>
>> # echo 0.903320312 > in_voltage0_scale	(enables the divider by two)
>
> Ok, so I have to remember this value : '0.903320312' in case I want to enable
> divide-by-two functionality?

No you don't. That's why there is a 'in_voltage_scale_available' that lists the 
available values.

> Hmmmm ... why would this interface not work:
> echo 2 > in_voltage0_scale
>
> or
>
> echo 1 > in_voltage0_scale

An easy thing like that is what I first submitted, but it was rejected and I was told 
to use the scale_available descriptor instead, which is the common interface the rest 
of drivers use.

Best regards,
--
Hector Palacios

  reply	other threads:[~2013-07-19 16:22 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  9:13 [PATCH v2 0/5] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-19  9:13 ` Hector Palacios
2013-07-19  9:13 ` [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-19  9:13   ` Hector Palacios
2013-07-19 13:56   ` Marek Vasut
2013-07-19 13:56     ` Marek Vasut
2013-07-19 17:09   ` Alexandre Belloni
2013-07-19 17:09     ` Alexandre Belloni
2013-07-19  9:13 ` [PATCH v2 2/5] ARM: dts: add reference voltage property for MXS LRADC Hector Palacios
2013-07-19  9:13   ` Hector Palacios
2013-07-19 13:58   ` Marek Vasut
2013-07-19 13:58     ` Marek Vasut
2013-07-19 17:10   ` Alexandre Belloni
2013-07-19 17:10     ` Alexandre Belloni
2013-07-19  9:13 ` [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-19  9:13   ` Hector Palacios
2013-07-19 14:30   ` Marek Vasut
2013-07-19 14:30     ` Marek Vasut
2013-07-19 15:44     ` Hector Palacios
2013-07-19 15:44       ` Hector Palacios
2013-07-19 16:14       ` Marek Vasut
2013-07-19 16:14         ` Marek Vasut
2013-07-22  7:22         ` Hector Palacios
2013-07-22  7:22           ` Hector Palacios
2013-07-22  7:42           ` Marek Vasut
2013-07-22  7:42             ` Marek Vasut
2013-07-22  7:46             ` Hector Palacios
2013-07-22  7:46               ` Hector Palacios
2013-07-22  7:58               ` Marek Vasut
2013-07-19 17:06   ` Alexandre Belloni
2013-07-19 17:06     ` Alexandre Belloni
2013-07-22  7:26     ` Hector Palacios
2013-07-22  7:26       ` Hector Palacios
2013-07-19  9:13 ` [PATCH v2 4/5] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-19  9:13   ` Hector Palacios
2013-07-19 17:20   ` Alexandre Belloni
2013-07-19 17:20     ` Alexandre Belloni
2013-07-19  9:13 ` [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-19  9:13   ` Hector Palacios
2013-07-19 14:39   ` Marek Vasut
2013-07-19 14:39     ` Marek Vasut
2013-07-19 15:31     ` Hector Palacios
2013-07-19 15:31       ` Hector Palacios
2013-07-19 16:17       ` Marek Vasut
2013-07-19 16:17         ` Marek Vasut
2013-07-19 16:22         ` Hector Palacios [this message]
2013-07-19 20:23           ` Jonathan Cameron
2013-07-19 20:23             ` Jonathan Cameron
2013-07-20 19:00             ` Marek Vasut
2013-07-20 19:00               ` Marek Vasut
2013-07-19 20:32       ` Jonathan Cameron
2013-07-19 20:32         ` Jonathan Cameron
2013-07-22  8:01         ` Hector Palacios
2013-07-22  8:01           ` Hector Palacios
2013-07-19 17:21   ` Alexandre Belloni
2013-07-19 17:21     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E967D8.8020001@digi.com \
    --to=hector.palacios@digi.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=fabio.estevam@freescale.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.