From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, marex@denx.de,
jic23@kernel.org, lars@metafoo.de, fabio.estevam@freescale.com
Subject: Re: [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12
Date: Fri, 19 Jul 2013 19:09:22 +0200 [thread overview]
Message-ID: <51E972C2.4040501@free-electrons.com> (raw)
In-Reply-To: <1374225208-28940-2-git-send-email-hector.palacios@digi.com>
On 19/07/2013 11:13, Hector Palacios wrote:
> The LRADC virtual channels have an 18 bit field to store the sum of up
> to 2^5 accumulated samples. The read_raw function however only operates
> over a single sample (12 bit resolution).
> In order to use this field for scaling operations, we need it to be the
> exact resolution value of the LRADC.
> Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
> report touch coordinates to userland. A 12 bit mask should be used instead
> or else the touch libraries will expect a coordinates range between 0
> and 0x3ffff (18 bits), instead of between 0 and 0xfff (12 bits).
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
>
Looks good to me:
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hector Palacios <hector.palacios-i7dp0qKlBMg@public.gmane.org>
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: Re: [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12
Date: Fri, 19 Jul 2013 19:09:22 +0200 [thread overview]
Message-ID: <51E972C2.4040501@free-electrons.com> (raw)
In-Reply-To: <1374225208-28940-2-git-send-email-hector.palacios-i7dp0qKlBMg@public.gmane.org>
On 19/07/2013 11:13, Hector Palacios wrote:
> The LRADC virtual channels have an 18 bit field to store the sum of up
> to 2^5 accumulated samples. The read_raw function however only operates
> over a single sample (12 bit resolution).
> In order to use this field for scaling operations, we need it to be the
> exact resolution value of the LRADC.
> Besides, the driver was using an 18 bit mask (LRADC_CH_VALUE_MASK) to
> report touch coordinates to userland. A 12 bit mask should be used instead
> or else the touch libraries will expect a coordinates range between 0
> and 0x3ffff (18 bits), instead of between 0 and 0xfff (12 bits).
>
> Signed-off-by: Hector Palacios <hector.palacios-i7dp0qKlBMg@public.gmane.org>
> ---
>
Looks good to me:
Acked-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-19 17:09 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:13 [PATCH v2 0/5] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 9:13 ` [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 13:56 ` Marek Vasut
2013-07-19 13:56 ` Marek Vasut
2013-07-19 17:09 ` Alexandre Belloni [this message]
2013-07-19 17:09 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 2/5] ARM: dts: add reference voltage property for MXS LRADC Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 13:58 ` Marek Vasut
2013-07-19 13:58 ` Marek Vasut
2013-07-19 17:10 ` Alexandre Belloni
2013-07-19 17:10 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 14:30 ` Marek Vasut
2013-07-19 14:30 ` Marek Vasut
2013-07-19 15:44 ` Hector Palacios
2013-07-19 15:44 ` Hector Palacios
2013-07-19 16:14 ` Marek Vasut
2013-07-19 16:14 ` Marek Vasut
2013-07-22 7:22 ` Hector Palacios
2013-07-22 7:22 ` Hector Palacios
2013-07-22 7:42 ` Marek Vasut
2013-07-22 7:42 ` Marek Vasut
2013-07-22 7:46 ` Hector Palacios
2013-07-22 7:46 ` Hector Palacios
2013-07-22 7:58 ` Marek Vasut
2013-07-19 17:06 ` Alexandre Belloni
2013-07-19 17:06 ` Alexandre Belloni
2013-07-22 7:26 ` Hector Palacios
2013-07-22 7:26 ` Hector Palacios
2013-07-19 9:13 ` [PATCH v2 4/5] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 17:20 ` Alexandre Belloni
2013-07-19 17:20 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-19 9:13 ` Hector Palacios
2013-07-19 14:39 ` Marek Vasut
2013-07-19 14:39 ` Marek Vasut
2013-07-19 15:31 ` Hector Palacios
2013-07-19 15:31 ` Hector Palacios
2013-07-19 16:17 ` Marek Vasut
2013-07-19 16:17 ` Marek Vasut
2013-07-19 16:22 ` Hector Palacios
2013-07-19 20:23 ` Jonathan Cameron
2013-07-19 20:23 ` Jonathan Cameron
2013-07-20 19:00 ` Marek Vasut
2013-07-20 19:00 ` Marek Vasut
2013-07-19 20:32 ` Jonathan Cameron
2013-07-19 20:32 ` Jonathan Cameron
2013-07-22 8:01 ` Hector Palacios
2013-07-22 8:01 ` Hector Palacios
2013-07-19 17:21 ` Alexandre Belloni
2013-07-19 17:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E972C2.4040501@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.