From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>, Alexander Graf <agraf@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)
Date: Sat, 20 Jul 2013 16:24:58 +0200 [thread overview]
Message-ID: <51EA9DBA.4080400@suse.de> (raw)
In-Reply-To: <51E98C93.8010508@weilnetz.de>
Am 19.07.2013 20:59, schrieb Stefan Weil:
> Am 19.07.2013 00:40, schrieb Alexander Graf:
>> On 18.07.2013, at 21:49, Stefan Weil wrote:
>>> Am 16.07.2013 07:54, schrieb Stefan Weil:
>>>> Am 12.07.2013 18:48, schrieb Stefan Weil:
>>>>> Hi Anthony,
>>>>>
>>>>> the patch fixes a build regression which was introduced today.
>>>>> Could you please apply it without waiting for the next pull requests?
>>>>>
>>>>> Thanks,
>>>>> Stefan
> [...]
>> Acked-by: Alexander Graf <agraf@suse.de> I assume this can go through
>> the trivial tree? Or directly get applied by Anthony? Alex
>
>
> I still think that build regressions should be fixed by a direct
> maintainer commit instead of waiting for a pull request,
> but obviously this does not happen here (why?).
Anthony recently stated very clearly that in order for him to pick up a
patch it needs to have a Reviewed-by. This one only got an Acked-by.
> So hopefully the fix will be committed via qemu-trivial at least.
It's not obvious from the diff context whether those specifiers are in
fact correct, and there is an active maintainer, so in theory it
wouldn't qualify for -trivial.
Alex, don't be lazy and just send a one-patch PULL like Cornelia did for
her recent mingw breakage. :)
Andreas
> See http://patchwork.ozlabs.org/patch/258774/ for the full patch.
>
> Stefan
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>, Alexander Graf <agraf@suse.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)
Date: Sat, 20 Jul 2013 16:24:58 +0200 [thread overview]
Message-ID: <51EA9DBA.4080400@suse.de> (raw)
In-Reply-To: <51E98C93.8010508@weilnetz.de>
Am 19.07.2013 20:59, schrieb Stefan Weil:
> Am 19.07.2013 00:40, schrieb Alexander Graf:
>> On 18.07.2013, at 21:49, Stefan Weil wrote:
>>> Am 16.07.2013 07:54, schrieb Stefan Weil:
>>>> Am 12.07.2013 18:48, schrieb Stefan Weil:
>>>>> Hi Anthony,
>>>>>
>>>>> the patch fixes a build regression which was introduced today.
>>>>> Could you please apply it without waiting for the next pull requests?
>>>>>
>>>>> Thanks,
>>>>> Stefan
> [...]
>> Acked-by: Alexander Graf <agraf@suse.de> I assume this can go through
>> the trivial tree? Or directly get applied by Anthony? Alex
>
>
> I still think that build regressions should be fixed by a direct
> maintainer commit instead of waiting for a pull request,
> but obviously this does not happen here (why?).
Anthony recently stated very clearly that in order for him to pick up a
patch it needs to have a Reviewed-by. This one only got an Acked-by.
> So hopefully the fix will be committed via qemu-trivial at least.
It's not obvious from the diff context whether those specifiers are in
fact correct, and there is an active maintainer, so in theory it
wouldn't qualify for -trivial.
Alex, don't be lazy and just send a one-patch PULL like Cornelia did for
her recent mingw breakage. :)
Andreas
> See http://patchwork.ozlabs.org/patch/258774/ for the full patch.
>
> Stefan
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-20 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 16:48 [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression) Stefan Weil
2013-07-16 5:54 ` Stefan Weil
2013-07-18 19:49 ` Stefan Weil
2013-07-18 22:40 ` Alexander Graf
2013-07-19 18:59 ` [Qemu-trivial] " Stefan Weil
2013-07-19 18:59 ` [Qemu-devel] " Stefan Weil
2013-07-20 14:24 ` Andreas Färber [this message]
2013-07-20 14:24 ` Andreas Färber
2013-07-21 14:58 ` [Qemu-trivial] " Stefan Weil
2013-07-21 14:58 ` Stefan Weil
2013-07-23 17:21 ` [Qemu-trivial] " Michael Tokarev
2013-07-23 17:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EA9DBA.4080400@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.