[PATCH] palo/paloio.c:64: warning: implicit declaration of function 'memcmp'

[PATCH] palo/paloio.c:64: warning: implicit declaration of function 'memcmp'

[Jeroen Roovers]

I have been carrying this patch in the Gentoo repository[1] for quite a
while now.

[1]
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-boot/palo/files/palo-1.18-include.patch?view=log

Add missing include for memcmp.

Signed-off-by: Jeroen Roovers <jer@gentoo.org>

diff --git a/palo/paloio.c b/palo/paloio.c
index 518c6a5..64e8e45 100644
--- a/a/palo/paloio.c
+++ b/b/palo/paloio.c
@@ -7,6 +7,7 @@
  */
 #include <unistd.h>
 #include <stdio.h>
+#include <string.h>
 #include <errno.h>
 #include <sys/types.h>
 #include <sys/stat.h>

[PATCH] palo/palo.c:482:5: /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments

[Jeroen Roovers]

In file included from /usr/include/fcntl.h:296:0,
                 from palo.c:16:
In function 'open',
    inlined from 'do_formatted' at palo.c:482:5:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode'
declared with attribute error: open with O_CREAT in second argument
needs 3 arguments

Signed-off-by: Jeroen Roovers <jer@gentoo.org>

diff --git a/palo/palo.c b/palo/palo.c
index 10031fd..fffb7ec 100644
--- a/palo/palo.c
+++ b/palo/palo.c
@@ -484,7 +484,7 @@ do_formatted(int init, int media, const char *medianame, int partition,
            error(14, "bootloader");

        sprintf(badblockfilename, "/tmp/paloblk-%d", getpid());
-       if ((fd = open(badblockfilename, O_RDWR | O_CREAT | O_TRUNC)) < 0) {
+       if ((fd = open(badblockfilename, O_RDWR | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) {
            perror(badblockfilename);
            exit(1);
        }

Re: [PATCH] palo/palo.c:482:5: /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments

[Helge Deller]

Hi Jeroen,

On 07/18/2013 05:43 PM, Jeroen Roovers wrote:
> In file included from /usr/include/fcntl.h:296:0,
>                  from palo.c:16:
> In function 'open',
>     inlined from 'do_formatted' at palo.c:482:5:
> /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode'
> declared with attribute error: open with O_CREAT in second argument
> needs 3 arguments
> 
> Signed-off-by: Jeroen Roovers <jer@gentoo.org>

Thanks for both patches!
I've just pushed both upstream to the palo git tree.

Both changes aren't that huge, so I'm right now not planning to
bump the version number - unless you need it for gentoo...?
Just let me know (or if you have further patches, e.g. gentoo specific files?)

Helge

Re: [PATCH] palo/palo.c:482:5: /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments

[Jeroen Roovers]

On Sat, 20 Jul 2013 21:53:10 +0200
Helge Deller <deller@gmx.de> wrote:

> Thanks for both patches!
> I've just pushed both upstream to the palo git tree.

Great!

> Both changes aren't that huge, so I'm right now not planning to
> bump the version number - unless you need it for gentoo...?

Both patches are already used in Gentoo, so that's fine.


     jer