* Re: [PATCH v4] xen/arm: enable PV control for ARM
@ 2013-07-23 0:32 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 12+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-07-23 0:32 UTC (permalink / raw)
To: Julien Grall, stefano.stabellini
Cc: ian.campbell, patches, linux-arm-kernel, linux-kernel, xen-devel
Julien Grall <julien.grall@linaro.org> wrote:
>Enable power management from the toolstack for ARM guest.
>
>Signed-off-by: Julien Grall <julien.grall@linaro.org>
>
>---
> Changes in v4:
> - Divide the patch in 2 distinct parts
> Changes in v3:
> - Fix condition to compile cpu_hotplug.o
> Changes in v2:
> - Don't compile xen/cpu_hotplug.o with ARM64
>---
> drivers/xen/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>index a609353..f185e8d 100644
>--- a/drivers/xen/Makefile
>+++ b/drivers/xen/Makefile
>@@ -1,9 +1,8 @@
> ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
>-obj-y += manage.o
> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> endif
> obj-$(CONFIG_X86) += fallback.o
>-obj-y += grant-table.o features.o events.o balloon.o time.o
>+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
> obj-y += xenbus/
>
> nostackp := $(call cc-option, -fno-stack-protector)
The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4] xen/arm: enable PV control for ARM
2013-07-23 0:32 ` Konrad Rzeszutek Wilk
@ 2013-07-23 10:52 ` Julien Grall
-1 siblings, 0 replies; 12+ messages in thread
From: Julien Grall @ 2013-07-23 10:52 UTC (permalink / raw)
To: linux-arm-kernel
On 07/23/2013 01:32 AM, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
>> Enable power management from the toolstack for ARM guest.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> ---
>> Changes in v4:
>> - Divide the patch in 2 distinct parts
>> Changes in v3:
>> - Fix condition to compile cpu_hotplug.o
>> Changes in v2:
>> - Don't compile xen/cpu_hotplug.o with ARM64
>> ---
>> drivers/xen/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index a609353..f185e8d 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -1,9 +1,8 @@
>> ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
>> -obj-y += manage.o
>> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
>> endif
>> obj-$(CONFIG_X86) += fallback.o
>> -obj-y += grant-table.o features.o events.o balloon.o time.o
>> +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
>> obj-y += xenbus/
>>
>> nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
What about : "Enable lifecycle (reboot, shutdown) management from the
toolstack for ARM guest"?
--
Julien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4] xen/arm: enable PV control for ARM
@ 2013-07-23 10:52 ` Julien Grall
0 siblings, 0 replies; 12+ messages in thread
From: Julien Grall @ 2013-07-23 10:52 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: stefano.stabellini, ian.campbell, patches, linux-arm-kernel,
linux-kernel, xen-devel
On 07/23/2013 01:32 AM, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
>> Enable power management from the toolstack for ARM guest.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> ---
>> Changes in v4:
>> - Divide the patch in 2 distinct parts
>> Changes in v3:
>> - Fix condition to compile cpu_hotplug.o
>> Changes in v2:
>> - Don't compile xen/cpu_hotplug.o with ARM64
>> ---
>> drivers/xen/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index a609353..f185e8d 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -1,9 +1,8 @@
>> ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
>> -obj-y += manage.o
>> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
>> endif
>> obj-$(CONFIG_X86) += fallback.o
>> -obj-y += grant-table.o features.o events.o balloon.o time.o
>> +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
>> obj-y += xenbus/
>>
>> nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
What about : "Enable lifecycle (reboot, shutdown) management from the
toolstack for ARM guest"?
--
Julien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4] xen/arm: enable PV control for ARM
2013-07-23 0:32 ` Konrad Rzeszutek Wilk
(?)
(?)
@ 2013-07-23 10:52 ` Julien Grall
-1 siblings, 0 replies; 12+ messages in thread
From: Julien Grall @ 2013-07-23 10:52 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: ian.campbell, patches, stefano.stabellini, linux-kernel,
xen-devel, linux-arm-kernel
On 07/23/2013 01:32 AM, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
>> Enable power management from the toolstack for ARM guest.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> ---
>> Changes in v4:
>> - Divide the patch in 2 distinct parts
>> Changes in v3:
>> - Fix condition to compile cpu_hotplug.o
>> Changes in v2:
>> - Don't compile xen/cpu_hotplug.o with ARM64
>> ---
>> drivers/xen/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index a609353..f185e8d 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -1,9 +1,8 @@
>> ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
>> -obj-y += manage.o
>> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
>> endif
>> obj-$(CONFIG_X86) += fallback.o
>> -obj-y += grant-table.o features.o events.o balloon.o time.o
>> +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
>> obj-y += xenbus/
>>
>> nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
What about : "Enable lifecycle (reboot, shutdown) management from the
toolstack for ARM guest"?
--
Julien
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4] xen/arm: enable PV control for ARM
2013-07-23 0:32 ` Konrad Rzeszutek Wilk
@ 2013-07-23 11:37 ` Stefano Stabellini
-1 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2013-07-23 11:37 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 22 Jul 2013, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
> >Enable power management from the toolstack for ARM guest.
> >
> >Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >
> >---
> > Changes in v4:
> > - Divide the patch in 2 distinct parts
> > Changes in v3:
> > - Fix condition to compile cpu_hotplug.o
> > Changes in v2:
> > - Don't compile xen/cpu_hotplug.o with ARM64
> >---
> > drivers/xen/Makefile | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> >index a609353..f185e8d 100644
> >--- a/drivers/xen/Makefile
> >+++ b/drivers/xen/Makefile
> >@@ -1,9 +1,8 @@
> > ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> >-obj-y += manage.o
> > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> > endif
> > obj-$(CONFIG_X86) += fallback.o
> >-obj-y += grant-table.o features.o events.o balloon.o time.o
> >+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
> > obj-y += xenbus/
> >
> > nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
That's a very x86-centric view of the world, but it's true that manage.c
is about shutdown, restart and other operations that don't fit under
"power management".
It could benefit from a better description.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4] xen/arm: enable PV control for ARM
@ 2013-07-23 11:37 ` Stefano Stabellini
0 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2013-07-23 11:37 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Julien Grall, stefano.stabellini, ian.campbell, patches,
linux-arm-kernel, linux-kernel, xen-devel
On Mon, 22 Jul 2013, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
> >Enable power management from the toolstack for ARM guest.
> >
> >Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >
> >---
> > Changes in v4:
> > - Divide the patch in 2 distinct parts
> > Changes in v3:
> > - Fix condition to compile cpu_hotplug.o
> > Changes in v2:
> > - Don't compile xen/cpu_hotplug.o with ARM64
> >---
> > drivers/xen/Makefile | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> >index a609353..f185e8d 100644
> >--- a/drivers/xen/Makefile
> >+++ b/drivers/xen/Makefile
> >@@ -1,9 +1,8 @@
> > ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> >-obj-y += manage.o
> > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> > endif
> > obj-$(CONFIG_X86) += fallback.o
> >-obj-y += grant-table.o features.o events.o balloon.o time.o
> >+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
> > obj-y += xenbus/
> >
> > nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
That's a very x86-centric view of the world, but it's true that manage.c
is about shutdown, restart and other operations that don't fit under
"power management".
It could benefit from a better description.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4] xen/arm: enable PV control for ARM
2013-07-23 0:32 ` Konrad Rzeszutek Wilk
` (3 preceding siblings ...)
(?)
@ 2013-07-23 11:37 ` Stefano Stabellini
-1 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2013-07-23 11:37 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: ian.campbell, patches, stefano.stabellini, Julien Grall,
linux-kernel, xen-devel, linux-arm-kernel
On Mon, 22 Jul 2013, Konrad Rzeszutek Wilk wrote:
> Julien Grall <julien.grall@linaro.org> wrote:
> >Enable power management from the toolstack for ARM guest.
> >
> >Signed-off-by: Julien Grall <julien.grall@linaro.org>
> >
> >---
> > Changes in v4:
> > - Divide the patch in 2 distinct parts
> > Changes in v3:
> > - Fix condition to compile cpu_hotplug.o
> > Changes in v2:
> > - Don't compile xen/cpu_hotplug.o with ARM64
> >---
> > drivers/xen/Makefile | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> >diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
> >index a609353..f185e8d 100644
> >--- a/drivers/xen/Makefile
> >+++ b/drivers/xen/Makefile
> >@@ -1,9 +1,8 @@
> > ifeq ($(filter y, $(CONFIG_ARM) $(CONFIG_ARM64)),)
> >-obj-y += manage.o
> > obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
> > endif
> > obj-$(CONFIG_X86) += fallback.o
> >-obj-y += grant-table.o features.o events.o balloon.o time.o
> >+obj-y += grant-table.o features.o events.o balloon.o time.o manage.o
> > obj-y += xenbus/
> >
> > nostackp := $(call cc-option, -fno-stack-protector)
>
> The patch looks Ok but the description is off. Power management is the term used for cpu freq, C states and P states. While this patch touches none of that.
>
That's a very x86-centric view of the world, but it's true that manage.c
is about shutdown, restart and other operations that don't fit under
"power management".
It could benefit from a better description.
^ permalink raw reply [flat|nested] 12+ messages in thread