All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] alsa-utils: fix wrong alias for signal.h
@ 2013-07-23  1:57 John Spencer
  2013-07-23 12:59 ` Jaroslav Kysela
  0 siblings, 1 reply; 2+ messages in thread
From: John Spencer @ 2013-07-23  1:57 UTC (permalink / raw)
  To: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

in POSIX, there is no <sys/signal.h>.

it's merely a legacy alias used by glibc, and the header does nothing 
else than including <signal.h>.

so let's do the right thing and use the right name, which works everywhere.

Signed-Off-By: John Spencer <maillist-alsa@barfooze.de>

[-- Attachment #2: alsa-utils_signal_h.patch --]
[-- Type: text/x-patch, Size: 341 bytes --]

--- alsa-utils-1.0.27.2.org/alsaloop/alsaloop.c	2013-07-23 01:48:03.592000003 +0000
+++ alsa-utils-1.0.27.2/alsaloop/alsaloop.c	2013-07-23 01:49:12.786000003 +0000
@@ -31,7 +31,7 @@
 #include <math.h>
 #include <pthread.h>
 #include <syslog.h>
-#include <sys/signal.h>
+#include <signal.h>
 #include "alsaloop.h"
 
 struct loopback_thread {

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] alsa-utils: fix wrong alias for signal.h
  2013-07-23  1:57 [PATCH] alsa-utils: fix wrong alias for signal.h John Spencer
@ 2013-07-23 12:59 ` Jaroslav Kysela
  0 siblings, 0 replies; 2+ messages in thread
From: Jaroslav Kysela @ 2013-07-23 12:59 UTC (permalink / raw)
  To: John Spencer; +Cc: alsa-devel

Date 23.7.2013 03:57, John Spencer wrote:
> in POSIX, there is no <sys/signal.h>.
> 
> it's merely a legacy alias used by glibc, and the header does nothing 
> else than including <signal.h>.
> 
> so let's do the right thing and use the right name, which works everywhere.
> 
> Signed-Off-By: John Spencer <maillist-alsa@barfooze.de>

I applied this patch to our git repo. Thanks.

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-23 12:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-23  1:57 [PATCH] alsa-utils: fix wrong alias for signal.h John Spencer
2013-07-23 12:59 ` Jaroslav Kysela

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.