From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/5] gpio: clean up gpio-ranges documentation
Date: Tue, 23 Jul 2013 09:14:11 -0700 [thread overview]
Message-ID: <51EEABD3.6000307@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdYsZ0aMnANPpTiGuD1U23PCqyvVGS7vOOnOQUks5KSk9g@mail.gmail.com>
On 07/22/2013 03:31 PM, Linus Walleij wrote:
> On Mon, Jul 15, 2013 at 8:40 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> This change makes documentation of the the gpio-ranges property shorter
>> and more succinct, more consistent with the style of the rest of the
>> document, and not mention Linux-specifics such as the API
>> pinctrl_request_gpio(); DT binding documents should be OS independant
>> where at all possible.
>>
>> This change also removes any mention of the #gpio-range-cells property.
>> Such properties are useful when one node references a second node, and
>> that second node dictates the format of the reference. However, that is
>> not the case here; the definition of gpio-ranges itself always dictates
>> its format entirely, and hence the value #gpio-range-cells must always
>> be 3, and hence there is no point requiring any referenced node to
>> include this property.
>> +It is useful to represent which GPIOs correspond to which pins on which pin
>> +controllers. The gpio-ranges property described below represents this, and
>> +contains information strucutres as follows:
>
> speling of strucutres
>
> Should you mention that this is given in BNF?
> Or is that implicit for all bindings?
The rest of the document already has a couple of other sections written
that way, so explicitly mentioning BNF seems like a logically unrelated
patch to fix a separate issue in the document. I didn't actually check
whether the syntax used here is strictly BNF either:-) Either way
though, I think it's easy enough to read the BNF without having to
explicitly know it's BNF or anything in-particular, so I'd err on the
side of not bothering to mention that myself...
I'll fix the other issues you mentioned locally, and wait for an ack for
drivers/of before reposting.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Warren <swarren@nvidia.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Rob Herring <rob.herring@calxeda.com>,
Shiraz Hashim <shiraz.hashim@st.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Jingchang Lu <b35083@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 1/5] gpio: clean up gpio-ranges documentation
Date: Tue, 23 Jul 2013 09:14:11 -0700 [thread overview]
Message-ID: <51EEABD3.6000307@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdYsZ0aMnANPpTiGuD1U23PCqyvVGS7vOOnOQUks5KSk9g@mail.gmail.com>
On 07/22/2013 03:31 PM, Linus Walleij wrote:
> On Mon, Jul 15, 2013 at 8:40 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> This change makes documentation of the the gpio-ranges property shorter
>> and more succinct, more consistent with the style of the rest of the
>> document, and not mention Linux-specifics such as the API
>> pinctrl_request_gpio(); DT binding documents should be OS independant
>> where at all possible.
>>
>> This change also removes any mention of the #gpio-range-cells property.
>> Such properties are useful when one node references a second node, and
>> that second node dictates the format of the reference. However, that is
>> not the case here; the definition of gpio-ranges itself always dictates
>> its format entirely, and hence the value #gpio-range-cells must always
>> be 3, and hence there is no point requiring any referenced node to
>> include this property.
>> +It is useful to represent which GPIOs correspond to which pins on which pin
>> +controllers. The gpio-ranges property described below represents this, and
>> +contains information strucutres as follows:
>
> speling of strucutres
>
> Should you mention that this is given in BNF?
> Or is that implicit for all bindings?
The rest of the document already has a couple of other sections written
that way, so explicitly mentioning BNF seems like a logically unrelated
patch to fix a separate issue in the document. I didn't actually check
whether the syntax used here is strictly BNF either:-) Either way
though, I think it's easy enough to read the BNF without having to
explicitly know it's BNF or anything in-particular, so I'd err on the
side of not bothering to mention that myself...
I'll fix the other issues you mentioned locally, and wait for an ack for
drivers/of before reposting.
next prev parent reply other threads:[~2013-07-23 16:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 18:40 [PATCH V2 1/5] gpio: clean up gpio-ranges documentation Stephen Warren
2013-07-15 18:40 ` Stephen Warren
2013-07-15 18:40 ` [PATCH V2 2/5] of: move documentation of of_parse_phandle_with_args Stephen Warren
2013-07-15 18:40 ` Stephen Warren
2013-07-15 18:40 ` [PATCH V2 3/5] of: introduce of_parse_phandle_with_fixed_args Stephen Warren
2013-07-15 18:40 ` Stephen Warren
2013-07-15 18:59 ` Sergei Shtylyov
2013-07-15 18:59 ` Sergei Shtylyov
2013-07-15 23:06 ` Stephen Warren
2013-07-15 23:06 ` Stephen Warren
2013-07-15 18:40 ` [PATCH V2 4/5] gpio: implement gpio-ranges binding document fix Stephen Warren
2013-07-15 18:40 ` Stephen Warren
2013-07-15 18:40 ` [PATCH V2 5/5] ARM: remove #gpio-ranges-cells property Stephen Warren
2013-07-15 18:40 ` Stephen Warren
2013-07-15 19:34 ` Rob Herring
2013-07-15 19:34 ` Rob Herring
2013-07-15 23:02 ` Stephen Warren
2013-07-15 23:02 ` Stephen Warren
2013-07-16 23:30 ` Stephen Warren
2013-07-16 23:30 ` Stephen Warren
2013-07-17 1:50 ` Rob Herring
2013-07-17 1:50 ` Rob Herring
2013-07-17 2:58 ` Stephen Warren
2013-07-17 2:58 ` Stephen Warren
2013-07-18 1:35 ` Laurent Pinchart
2013-07-18 1:35 ` Laurent Pinchart
2013-07-22 22:31 ` [PATCH V2 1/5] gpio: clean up gpio-ranges documentation Linus Walleij
2013-07-22 22:31 ` Linus Walleij
2013-07-23 16:14 ` Stephen Warren [this message]
2013-07-23 16:14 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEABD3.6000307@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.