From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Steve Glendinning <steve.glendinning@shawell.net>,
netdev@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH 1/4] net: smsc911x: add support for a reset GPIO
Date: Tue, 23 Jul 2013 17:36:46 +0000 [thread overview]
Message-ID: <51EEBF2E.5080604@cogentembedded.com> (raw)
In-Reply-To: <1374595924-12338-2-git-send-email-g.liakhovetski@gmx.de>
Hello.
On 07/23/2013 08:12 PM, Guennadi Liakhovetski wrote:
> If a reset GPIO is specified in platform data, take the controller out of
> reset before using it.
A small typo in the comment...
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
[...]
> diff --git a/include/linux/smsc911x.h b/include/linux/smsc911x.h
> index 4dde70e..4e3e49d 100644
> --- a/include/linux/smsc911x.h
> +++ b/include/linux/smsc911x.h
> @@ -32,8 +32,18 @@ struct smsc911x_platform_config {
> unsigned int shift;
> phy_interface_t phy_interface;
> unsigned char mac[6];
> + unsigned int reset_gpio;
> + unsigned int reset_gpio_config;
> };
>
> +/*
> + * Bits for platform_device reest GPIO configuration: an OR of any GPIOF_* flags
s/reest/reset/
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Steve Glendinning <steve.glendinning@shawell.net>,
netdev@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH 1/4] net: smsc911x: add support for a reset GPIO
Date: Tue, 23 Jul 2013 21:36:46 +0400 [thread overview]
Message-ID: <51EEBF2E.5080604@cogentembedded.com> (raw)
In-Reply-To: <1374595924-12338-2-git-send-email-g.liakhovetski@gmx.de>
Hello.
On 07/23/2013 08:12 PM, Guennadi Liakhovetski wrote:
> If a reset GPIO is specified in platform data, take the controller out of
> reset before using it.
A small typo in the comment...
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
[...]
> diff --git a/include/linux/smsc911x.h b/include/linux/smsc911x.h
> index 4dde70e..4e3e49d 100644
> --- a/include/linux/smsc911x.h
> +++ b/include/linux/smsc911x.h
> @@ -32,8 +32,18 @@ struct smsc911x_platform_config {
> unsigned int shift;
> phy_interface_t phy_interface;
> unsigned char mac[6];
> + unsigned int reset_gpio;
> + unsigned int reset_gpio_config;
> };
>
> +/*
> + * Bits for platform_device reest GPIO configuration: an OR of any GPIOF_* flags
s/reest/reset/
WBR, Sergei
next prev parent reply other threads:[~2013-07-23 17:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 16:12 [PATCH 0/4] net: smsc911x: support reset GPIO and use it on ape6evm Guennadi Liakhovetski
2013-07-23 16:12 ` Guennadi Liakhovetski
2013-07-23 16:12 ` [PATCH 1/4] net: smsc911x: add support for a reset GPIO Guennadi Liakhovetski
2013-07-23 16:12 ` Guennadi Liakhovetski
2013-07-23 16:38 ` Fabio Estevam
2013-07-23 16:38 ` Fabio Estevam
2013-07-23 16:44 ` Guennadi Liakhovetski
2013-07-23 16:44 ` Guennadi Liakhovetski
2013-07-23 17:36 ` Sergei Shtylyov [this message]
2013-07-23 17:36 ` Sergei Shtylyov
2013-07-23 16:12 ` [PATCH 2/4] net: smsc911x: add a reset GPIO DT binding Guennadi Liakhovetski
2013-07-23 16:12 ` Guennadi Liakhovetski
2013-07-23 22:10 ` Laurent Pinchart
2013-07-23 22:10 ` Laurent Pinchart
2013-07-23 22:18 ` Sascha Hauer
2013-07-23 22:18 ` Sascha Hauer
2013-07-23 16:12 ` [PATCH 3/4] ARM: shmobile: ape6evm: use smsc911x platform parameters to handle eth reset Guennadi Liakhovetski
2013-07-23 16:12 ` Guennadi Liakhovetski
2013-07-23 16:12 ` [PATCH 4/4] ARM: shmobile: ape6evm-reference: add smsc911x ethernet support Guennadi Liakhovetski
2013-07-23 16:12 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEBF2E.5080604@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=g.liakhovetski+renesas@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.