From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device
Date: Tue, 23 Jul 2013 11:15:12 -0700 [thread overview]
Message-ID: <51EEC830.9000407@wwwdotorg.org> (raw)
In-Reply-To: <51EE968B.1050103-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 07/23/2013 07:43 AM, Laxman Dewangan wrote:
> On Tuesday 23 July 2013 03:39 PM, Joseph Lo wrote:
>> The IRQ trigger type of Palmas MFD device (tps65913) is low-level
>> sensitive. The wrong configuration would cause an interrupt storm
>> when booting the system. Fixing it in DT with appropriate interrupt
>> type.
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts
>> palmas: tps65913 {
>> compatible = "ti,palmas";
>> reg = <0x58>;
>> - interrupts = <0 86 0x4>;
>> + interrupts = <0 86 0x8>;
>
> This fails as GIC does not support the interrupt flag of 8.
...
> I did not get the interrupt storm and even interrupt is not working on tot.
> Two ways to resolve this:
> - Change the interrupt flag to 0 from 4. Or
> - Remove the nvidia,invert-interrupt; for PMC node.
Yes, use the PMIC property please.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device
Date: Tue, 23 Jul 2013 11:15:12 -0700 [thread overview]
Message-ID: <51EEC830.9000407@wwwdotorg.org> (raw)
In-Reply-To: <51EE968B.1050103@nvidia.com>
On 07/23/2013 07:43 AM, Laxman Dewangan wrote:
> On Tuesday 23 July 2013 03:39 PM, Joseph Lo wrote:
>> The IRQ trigger type of Palmas MFD device (tps65913) is low-level
>> sensitive. The wrong configuration would cause an interrupt storm
>> when booting the system. Fixing it in DT with appropriate interrupt
>> type.
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts
>> palmas: tps65913 {
>> compatible = "ti,palmas";
>> reg = <0x58>;
>> - interrupts = <0 86 0x4>;
>> + interrupts = <0 86 0x8>;
>
> This fails as GIC does not support the interrupt flag of 8.
...
> I did not get the interrupt storm and even interrupt is not working on tot.
> Two ways to resolve this:
> - Change the interrupt flag to 0 from 4. Or
> - Remove the nvidia,invert-interrupt; for PMC node.
Yes, use the PMIC property please.
next prev parent reply other threads:[~2013-07-23 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 10:09 [PATCH] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device Joseph Lo
2013-07-23 10:09 ` Joseph Lo
[not found] ` <1374574191-24396-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-23 14:43 ` Laxman Dewangan
2013-07-23 14:43 ` Laxman Dewangan
[not found] ` <51EE968B.1050103-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-23 18:15 ` Stephen Warren [this message]
2013-07-23 18:15 ` Stephen Warren
2013-07-24 6:56 ` Joseph Lo
2013-07-24 6:56 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEC830.9000407@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.