From: Eric Sandeen <sandeen@redhat.com>
To: "\"Jóhann B. Guðmundsson\"" <johannbg@gmail.com>
Cc: "Theodore Tso" <tytso@mit.edu>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"\"Jóhann B. Guðmundsson\"" <johannbg@fedoraproject.org>
Subject: Re: [PATCH 1/1] ext4: Fix Opts: (null)
Date: Tue, 23 Jul 2013 21:18:56 -0500 [thread overview]
Message-ID: <51EF3990.4010901@redhat.com> (raw)
In-Reply-To: <1374531868-1800-1-git-send-email-johannbg@fedoraproject.org>
On 7/22/13 5:24 PM, Jóhann B. Guðmundsson wrote:
> null null null no more Opts: (null) but something that actually makes sense to
> human beings...
It's not clear to me how this changes the (null) output...
Have you tested it? What's the difference in output?
-Eric
> Signed-off-by: Jóhann B. Guðmundsson <johannbg@fedoraproject.org>
> ---
> fs/ext4/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 85b3dd6..ef141b7 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4088,8 +4088,8 @@ no_journal:
> "the device does not support discard");
> }
>
> - ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
> - "Opts: %s%s%s", descr, sbi->s_es->s_mount_opts,
> + ext4_msg(sb, KERN_INFO, "mounted filesystem with%s "
> + "%s%s%s mount option(s)", descr, sbi->s_es->s_mount_opts,
> *sbi->s_es->s_mount_opts ? "; " : "", orig_data);
>
> if (es->s_error_count)
> @@ -4866,7 +4866,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data)
> }
> #endif
>
> - ext4_msg(sb, KERN_INFO, "re-mounted. Opts: %s", orig_data);
> + ext4_msg(sb, KERN_INFO, "re-mounted %s mount option(s)", orig_data);
> kfree(orig_data);
> return 0;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Sandeen <sandeen@redhat.com>
To: "\"Jóhann B. Guðmundsson\"" <johannbg@gmail.com>
Cc: "Theodore Tso" <tytso@mit.edu>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"\"Jóhann B. Guðmundsson\"" <johannbg@fedoraproject.org>
Subject: Re: [PATCH 1/1] ext4: Fix Opts: (null)
Date: Tue, 23 Jul 2013 21:18:56 -0500 [thread overview]
Message-ID: <51EF3990.4010901@redhat.com> (raw)
In-Reply-To: <1374531868-1800-1-git-send-email-johannbg@fedoraproject.org>
On 7/22/13 5:24 PM, Jóhann B. Guðmundsson wrote:
> null null null no more Opts: (null) but something that actually makes sense to
> human beings...
It's not clear to me how this changes the (null) output...
Have you tested it? What's the difference in output?
-Eric
> Signed-off-by: Jóhann B. Guðmundsson <johannbg@fedoraproject.org>
> ---
> fs/ext4/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 85b3dd6..ef141b7 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4088,8 +4088,8 @@ no_journal:
> "the device does not support discard");
> }
>
> - ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
> - "Opts: %s%s%s", descr, sbi->s_es->s_mount_opts,
> + ext4_msg(sb, KERN_INFO, "mounted filesystem with%s "
> + "%s%s%s mount option(s)", descr, sbi->s_es->s_mount_opts,
> *sbi->s_es->s_mount_opts ? "; " : "", orig_data);
>
> if (es->s_error_count)
> @@ -4866,7 +4866,7 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data)
> }
> #endif
>
> - ext4_msg(sb, KERN_INFO, "re-mounted. Opts: %s", orig_data);
> + ext4_msg(sb, KERN_INFO, "re-mounted %s mount option(s)", orig_data);
> kfree(orig_data);
> return 0;
>
>
next prev parent reply other threads:[~2013-07-24 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 22:24 [PATCH 1/1] ext4: Fix Opts: (null) Jóhann B. Guðmundsson
2013-07-24 2:18 ` Eric Sandeen [this message]
2013-07-24 2:18 ` Eric Sandeen
2013-07-24 9:02 ` "Jóhann B. Guðmundsson"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF3990.4010901@redhat.com \
--to=sandeen@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=johannbg@fedoraproject.org \
--cc=johannbg@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.