From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] regulator: palmas: fix pdata ptr not be updated after it has been allocated
Date: Wed, 24 Jul 2013 13:09:34 -0400 [thread overview]
Message-ID: <51F00A4E.1020100@nvidia.com> (raw)
In-Reply-To: <20130724170215.GP9858-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 7/24/2013 1:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 24, 2013 at 12:28:02PM -0400, Rhyland Klein wrote:
>
>> + /* Store the pdata pointer after everything else passes */
>> + pdev->dev.platform_data = pdata;
>
> No, this is bad - the driver should not be modifying the platform_data
> pointer, it's owned by the thing that created the device. If the
> platform data needs to be modified it should be copied somewhere in the
> driver data.
Alright, thanks.
-rhyland
>
> * Unknown Key
> * 0x7EA229BD
>
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Rhyland Klein <rklein@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Joseph Lo <josephl@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] regulator: palmas: fix pdata ptr not be updated after it has been allocated
Date: Wed, 24 Jul 2013 13:09:34 -0400 [thread overview]
Message-ID: <51F00A4E.1020100@nvidia.com> (raw)
In-Reply-To: <20130724170215.GP9858@sirena.org.uk>
On 7/24/2013 1:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jul 24, 2013 at 12:28:02PM -0400, Rhyland Klein wrote:
>
>> + /* Store the pdata pointer after everything else passes */
>> + pdev->dev.platform_data = pdata;
>
> No, this is bad - the driver should not be modifying the platform_data
> pointer, it's owned by the thing that created the device. If the
> platform data needs to be modified it should be copied somewhere in the
> driver data.
Alright, thanks.
-rhyland
>
> * Unknown Key
> * 0x7EA229BD
>
--
nvpublic
next prev parent reply other threads:[~2013-07-24 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 16:28 [PATCH] regulator: palmas: fix pdata ptr not be updated after it has been allocated Rhyland Klein
2013-07-24 16:28 ` Rhyland Klein
[not found] ` <1374683282-17517-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-24 17:02 ` Mark Brown
2013-07-24 17:02 ` Mark Brown
[not found] ` <20130724170215.GP9858-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-24 17:09 ` Rhyland Klein [this message]
2013-07-24 17:09 ` Rhyland Klein
2013-07-24 17:20 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F00A4E.1020100@nvidia.com \
--to=rklein-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.