All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	mchehab@redhat.com, linux-media@vger.kernel.org,
	magnus.damm@gmail.com, linux-sh@vger.kernel.org,
	phil.edworthy@renesas.com, matsu@igel.co.jp
Subject: Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
Date: Wed, 24 Jul 2013 19:36:01 +0000	[thread overview]
Message-ID: <51F02CA1.7050603@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1307241731560.2179@axis700.grange>

Hi Guennadi,

Thank you for the v8 review.

On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
> [snip]
>> +	/* output format */
>> +	switch (icd->current_fmt->host_fmt->fourcc) {
>> +	case V4L2_PIX_FMT_NV16:
>> +		iowrite32(ALIGN(cam->width * cam->height, 0x80),
>> +			  priv->base + VNUVAOF_REG);
>> +		dmr = VNDMR_DTMD_YCSEP;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_YUYV:
>> +		dmr = VNDMR_BPSM;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_UYVY:
>> +		dmr = 0;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB555X:
>> +		dmr = VNDMR_DTMD_ARGB1555;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB565:
>> +		dmr = 0;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB32:
>> +		if (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) {
>> +			dmr = VNDMR_EXRGB;
>> +			break;
>> +		}
>> +	default:
>> +		BUG();
> as commented above, please, remove
Does WARN_ON(1) work instead of removal?

Regards,
Vladimir


WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	mchehab@redhat.com, linux-media@vger.kernel.org,
	magnus.damm@gmail.com, linux-sh@vger.kernel.org,
	phil.edworthy@renesas.com, matsu@igel.co.jp
Subject: Re: [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver
Date: Wed, 24 Jul 2013 23:36:01 +0400	[thread overview]
Message-ID: <51F02CA1.7050603@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1307241731560.2179@axis700.grange>

Hi Guennadi,

Thank you for the v8 review.

On 07/24/2013 08:14 PM, Guennadi Liakhovetski wrote:
> [snip]
>> +	/* output format */
>> +	switch (icd->current_fmt->host_fmt->fourcc) {
>> +	case V4L2_PIX_FMT_NV16:
>> +		iowrite32(ALIGN(cam->width * cam->height, 0x80),
>> +			  priv->base + VNUVAOF_REG);
>> +		dmr = VNDMR_DTMD_YCSEP;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_YUYV:
>> +		dmr = VNDMR_BPSM;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_UYVY:
>> +		dmr = 0;
>> +		output_is_yuv = true;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB555X:
>> +		dmr = VNDMR_DTMD_ARGB1555;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB565:
>> +		dmr = 0;
>> +		break;
>> +	case V4L2_PIX_FMT_RGB32:
>> +		if (priv->chip == RCAR_H1 || priv->chip == RCAR_E1) {
>> +			dmr = VNDMR_EXRGB;
>> +			break;
>> +		}
>> +	default:
>> +		BUG();
> as commented above, please, remove
Does WARN_ON(1) work instead of removal?

Regards,
Vladimir


  reply	other threads:[~2013-07-24 19:36 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19 23:14 [PATCH v8] V4L2: soc_camera: Renesas R-Car VIN driver Sergei Shtylyov
2013-07-19 23:14 ` Sergei Shtylyov
2013-07-24 16:14 ` Guennadi Liakhovetski
2013-07-24 16:14   ` Guennadi Liakhovetski
2013-07-24 19:36   ` Vladimir Barinov [this message]
2013-07-24 19:36     ` Vladimir Barinov
2013-07-24 20:38     ` Guennadi Liakhovetski
2013-07-24 20:38       ` Guennadi Liakhovetski
2013-07-24 19:40   ` Sergei Shtylyov
2013-07-24 19:40     ` Sergei Shtylyov
2013-07-24 20:26     ` Guennadi Liakhovetski
2013-07-24 20:26       ` Guennadi Liakhovetski
  -- strict thread matches above, loose matches on Subject: below --
2013-05-23 22:11 [PATCH v6] " Sergei Shtylyov
2013-05-23 22:11 ` Sergei Shtylyov
2013-06-02 18:56 ` Sergei Shtylyov
2013-06-02 18:56   ` Sergei Shtylyov
2013-06-04  1:08   ` Simon Horman
2013-06-04  1:08     ` Simon Horman
2013-06-13 13:12 ` Guennadi Liakhovetski
2013-06-13 13:12   ` Guennadi Liakhovetski
2013-06-21  0:50   ` Vladimir Barinov
2013-06-21  0:50     ` Vladimir Barinov
2013-06-21 20:08   ` Sergei Shtylyov
2013-06-21 20:08     ` Sergei Shtylyov
2013-06-21  4:46 ` Katsuya MATSUBARA
2013-06-21  4:46   ` Katsuya MATSUBARA
2013-06-21  8:06   ` Vladimir Barinov
2013-06-21  8:06     ` Vladimir Barinov
2013-06-21  9:09     ` Katsuya MATSUBARA
2013-06-21  9:09       ` Katsuya MATSUBARA
2013-06-21  9:39       ` Vladimir Barinov
2013-06-21  9:39         ` Vladimir Barinov
2013-06-21 10:01         ` Katsuya MATSUBARA
2013-06-21 10:01           ` Katsuya MATSUBARA
2013-06-21 10:32           ` Vladimir Barinov
2013-06-21 10:32             ` Vladimir Barinov
2013-06-21 13:04             ` Katsuya MATSUBARA
2013-06-21 13:04               ` Katsuya MATSUBARA
2013-06-22 11:45               ` Vladimir Barinov
2013-06-22 11:45                 ` Vladimir Barinov
2013-07-25  3:01                 ` [PATCH v8] " Katsuya MATSUBARA
2013-07-25  3:01                   ` Katsuya MATSUBARA
2013-07-25  6:55                   ` Vladimir Barinov
2013-07-25  6:55                     ` Vladimir Barinov
2013-07-25  7:29                     ` Katsuya MATSUBARA
2013-07-25  7:29                       ` Katsuya MATSUBARA
2013-07-26 11:11                       ` Guennadi Liakhovetski
2013-07-26 11:11                         ` Guennadi Liakhovetski
2013-07-30  7:36                         ` Katsuya MATSUBARA
2013-07-30  7:36                           ` Katsuya MATSUBARA
2013-07-30  7:45                           ` Guennadi Liakhovetski
2013-07-30  7:45                             ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F02CA1.7050603@cogentembedded.com \
    --to=vladimir.barinov@cogentembedded.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=matsu@igel.co.jp \
    --cc=mchehab@redhat.com \
    --cc=phil.edworthy@renesas.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.