From: Dave Hansen <dave@sr71.net>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
andi@firstfloor.org, akpm@linux-foundation.org,
linux-mm@kvack.org, kamezawa.hiroyuki@gmail.com, mhocko@suse.cz,
hannes@cmpxchg.org, yinghan@google.com
Subject: Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context"
Date: Wed, 24 Jul 2013 14:04:15 -0700 [thread overview]
Message-ID: <51F0414F.3060600@sr71.net> (raw)
In-Reply-To: <1374701399-30842-2-git-send-email-kys@microsoft.com>
On 07/24/2013 02:29 PM, K. Y. Srinivasan wrote:
> /*
> - * Wait for the memory block to be onlined.
> - * Since the hot add has succeeded, it is ok to
> - * proceed even if the pages in the hot added region
> - * have not been "onlined" within the allowed time.
> + * Before proceeding to hot add the next segment,
> + * online the segment that has been hot added.
> */
> - wait_for_completion_timeout(&dm_device.ol_waitevent, 5*HZ);
> + online_memory_block(start_pfn);
Ahhhhh.... You've got a timeout in the code in order to tell the
hypervisor that you were successfully able to add the memory? The
userspace addition code probably wasn't running within this timeout
period. right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
andi@firstfloor.org, akpm@linux-foundation.org,
linux-mm@kvack.org, kamezawa.hiroyuki@gmail.com, mhocko@suse.cz,
hannes@cmpxchg.org, yinghan@google.com
Subject: Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context"
Date: Wed, 24 Jul 2013 14:04:15 -0700 [thread overview]
Message-ID: <51F0414F.3060600@sr71.net> (raw)
In-Reply-To: <1374701399-30842-2-git-send-email-kys@microsoft.com>
On 07/24/2013 02:29 PM, K. Y. Srinivasan wrote:
> /*
> - * Wait for the memory block to be onlined.
> - * Since the hot add has succeeded, it is ok to
> - * proceed even if the pages in the hot added region
> - * have not been "onlined" within the allowed time.
> + * Before proceeding to hot add the next segment,
> + * online the segment that has been hot added.
> */
> - wait_for_completion_timeout(&dm_device.ol_waitevent, 5*HZ);
> + online_memory_block(start_pfn);
Ahhhhh.... You've got a timeout in the code in order to tell the
hypervisor that you were successfully able to add the memory? The
userspace addition code probably wasn't running within this timeout
period. right?
next prev parent reply other threads:[~2013-07-24 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 21:29 [PATCH 0/2] Drivers: hv: balloon: Online memory segments "in context" K. Y. Srinivasan
2013-07-24 21:29 ` K. Y. Srinivasan
2013-07-24 21:29 ` [PATCH 1/2] Drivers: base: memory: Export functionality for "in kernel" onlining of memory K. Y. Srinivasan
2013-07-24 21:29 ` K. Y. Srinivasan
2013-07-24 21:29 ` [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context" K. Y. Srinivasan
2013-07-24 21:29 ` K. Y. Srinivasan
2013-07-24 21:04 ` Dave Hansen [this message]
2013-07-24 21:04 ` Dave Hansen
2013-07-24 21:10 ` KY Srinivasan
2013-07-24 21:10 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F0414F.3060600@sr71.net \
--to=dave@sr71.net \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyuki@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=olaf@aepfle.de \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.