From: Josh Wu <josh.wu@atmel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
<jic23@cam.ac.uk>, <linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <plagnioj@jcrosoft.com>,
<nicolas.ferre@atmel.com>
Subject: Re: [PATCH 4/5] iio: at91: add an optional dt property for for adc clock hz.
Date: Thu, 25 Jul 2013 15:29:07 +0800 [thread overview]
Message-ID: <51F0D3C3.5090201@atmel.com> (raw)
In-Reply-To: <51E52B9B.5030407@metafoo.de>
On 7/16/2013 7:16 PM, Lars-Peter Clausen wrote:
> On 07/16/2013 12:30 PM, Maxime Ripard wrote:
> [...]
>>> After a further thinking of this, maybe remove the adc_op_clk is
>>> better since it is a fake clock, and only used to specify the clock
>>> rate.
>>> To specify the clock rate use a dt property or platform data
>>> parameter is better.
>> No, to specify *any* clock, the common clock framework is the better
>> solution.
> Yep, this patch is not the right approach. It's trying to work around the
> limitations of the platforms clock API implementation. Please fix the at91
> clock implementation instead (e.g. by switching to the common clock framework).
Thank you and Maxime for the clarify. I will drop this patch in next
version.
Just FYI. The at91 clock common framework is in implementation by Boris
Brezillion.
>
> - Lars
>
Best Regards,
Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] iio: at91: add an optional dt property for for adc clock hz.
Date: Thu, 25 Jul 2013 15:29:07 +0800 [thread overview]
Message-ID: <51F0D3C3.5090201@atmel.com> (raw)
In-Reply-To: <51E52B9B.5030407@metafoo.de>
On 7/16/2013 7:16 PM, Lars-Peter Clausen wrote:
> On 07/16/2013 12:30 PM, Maxime Ripard wrote:
> [...]
>>> After a further thinking of this, maybe remove the adc_op_clk is
>>> better since it is a fake clock, and only used to specify the clock
>>> rate.
>>> To specify the clock rate use a dt property or platform data
>>> parameter is better.
>> No, to specify *any* clock, the common clock framework is the better
>> solution.
> Yep, this patch is not the right approach. It's trying to work around the
> limitations of the platforms clock API implementation. Please fix the at91
> clock implementation instead (e.g. by switching to the common clock framework).
Thank you and Maxime for the clarify. I will drop this patch in next
version.
Just FYI. The at91 clock common framework is in implementation by Boris
Brezillion.
>
> - Lars
>
Best Regards,
Josh Wu
next prev parent reply other threads:[~2013-07-25 7:29 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-14 8:04 [PATCH 0/5] iio: at91: Add touch screen support in at91 adc Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-14 8:04 ` [PATCH 1/5] iio: at91: use adc_clk_khz to make the calculation not easy to large than u32 Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-15 12:52 ` Maxime Ripard
2013-07-15 12:52 ` Maxime Ripard
2013-07-16 7:54 ` Josh Wu
2013-07-16 7:54 ` Josh Wu
2013-07-14 8:04 ` [PATCH 2/5] iio: at91: Use different prescal, startup mask in MR for different IP Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-15 12:58 ` Maxime Ripard
2013-07-15 12:58 ` Maxime Ripard
2013-07-16 8:35 ` Josh Wu
2013-07-16 8:35 ` Josh Wu
2013-07-16 8:46 ` Nicolas Ferre
2013-07-16 8:46 ` Nicolas Ferre
2013-07-16 11:20 ` Maxime Ripard
2013-07-16 11:20 ` Maxime Ripard
2013-07-16 11:30 ` Thomas Petazzoni
2013-07-16 11:30 ` Thomas Petazzoni
2013-07-16 11:30 ` Thomas Petazzoni
2013-07-16 19:03 ` Jonathan Cameron
2013-07-16 19:03 ` Jonathan Cameron
2013-07-16 19:03 ` Jonathan Cameron
2013-07-16 19:17 ` Thomas Petazzoni
2013-07-16 19:17 ` Thomas Petazzoni
2013-07-16 19:17 ` Thomas Petazzoni
2013-07-17 8:23 ` Nicolas Ferre
2013-07-17 8:23 ` Nicolas Ferre
2013-07-17 8:23 ` Nicolas Ferre
2013-07-17 8:12 ` Nicolas Ferre
2013-07-17 8:12 ` Nicolas Ferre
2013-07-17 9:07 ` Josh Wu
2013-07-17 9:07 ` Josh Wu
2013-07-17 15:40 ` Maxime Ripard
2013-07-17 15:40 ` Maxime Ripard
2013-07-17 7:58 ` Nicolas Ferre
2013-07-17 7:58 ` Nicolas Ferre
2013-07-17 10:09 ` Josh Wu
2013-07-17 10:09 ` Josh Wu
2013-07-20 9:35 ` Jonathan Cameron
2013-07-20 9:35 ` Jonathan Cameron
2013-07-14 8:04 ` [PATCH 3/5] iio: at91: ADC start-up time calculation changed since at91sam9x5 Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-20 9:39 ` Jonathan Cameron
2013-07-20 9:39 ` Jonathan Cameron
2013-07-25 7:35 ` Josh Wu
2013-07-25 7:35 ` Josh Wu
2013-07-14 8:04 ` [PATCH 4/5] iio: at91: add an optional dt property for for adc clock hz Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-15 13:06 ` Maxime Ripard
2013-07-15 13:06 ` Maxime Ripard
2013-07-16 7:55 ` Josh Wu
2013-07-16 7:55 ` Josh Wu
2013-07-16 10:30 ` Maxime Ripard
2013-07-16 10:30 ` Maxime Ripard
2013-07-16 11:16 ` Lars-Peter Clausen
2013-07-16 11:16 ` Lars-Peter Clausen
2013-07-25 7:29 ` Josh Wu [this message]
2013-07-25 7:29 ` Josh Wu
2013-07-25 12:01 ` boris brezillon
2013-07-25 12:01 ` boris brezillon
2013-07-25 12:11 ` boris brezillon
2013-07-25 12:11 ` boris brezillon
2013-07-14 8:04 ` [PATCH 5/5] iio: at91: introduce touch screen support in iio adc driver Josh Wu
2013-07-14 8:04 ` Josh Wu
2013-07-15 13:15 ` Maxime Ripard
2013-07-15 13:15 ` Maxime Ripard
2013-07-16 9:09 ` Josh Wu
2013-07-16 9:09 ` Josh Wu
2013-07-16 11:43 ` Maxime Ripard
2013-07-16 11:43 ` Maxime Ripard
[not found] ` <1373789069-11604-6-git-send-email-josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-07-20 9:57 ` Jonathan Cameron
2013-07-20 9:57 ` Jonathan Cameron
2013-07-20 9:57 ` Jonathan Cameron
2013-07-22 13:17 ` Mark Rutland
2013-07-22 13:17 ` Mark Rutland
2013-07-25 7:56 ` Josh Wu
2013-07-25 7:56 ` Josh Wu
2013-07-25 16:45 ` Mark Rutland
2013-07-25 16:45 ` Mark Rutland
2013-08-06 10:24 ` Josh Wu
2013-08-06 10:24 ` Josh Wu
2013-08-08 13:40 ` Mark Rutland
2013-08-08 13:40 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F0D3C3.5090201@atmel.com \
--to=josh.wu@atmel.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.