Re: [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3

[Chad Versace <chad.versace@linux.intel.com>]

On 07/24/2013 05:04 PM, Jesse Barnes wrote:
> For use by userspace (at some point in the future) and other kernel code.
>
> v2: move PCI IDs to uabi (Chris)
>      move PCI IDs to drm/ (Dave)
> v3: fixup Quanta detection - needs to come first (Daniel)
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>   drivers/gpu/drm/i915/i915_drv.c |  164 +++++++-----------------------
>   include/drm/i915_drm.h          |    2 +
>   include/drm/i915_pciids.h       |  208 +++++++++++++++++++++++++++++++++++++++
>   3 files changed, 244 insertions(+), 130 deletions(-)
>   create mode 100644 include/drm/i915_pciids.h


> +#define INTEL_VGA_DEVICE(id, info) {		\
> +	.class = PCI_BASE_CLASS_DISPLAY << 16,	\
> +	.class_mask = 0xff0000,			\
> +	.vendor = 0x8086,			\
> +	.device = id,				\
> +	.subvendor = PCI_ANY_ID,		\
> +	.subdevice = PCI_ANY_ID,		\
> +	.driver_data = (unsigned long) info }

I retract my objections from yesterday. I expected the header to define
a static table (like static const struct xxx i915_pci_ids[] = ...), which
I didn't like due its inflexibility. But, this macro I do like. It's
flexible enough.

Acked-by: Chad Versace <chad.versace@linux.intel.com>