All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Radovan Lekanovic <Radovan.Lekanovic@sonymobile.com>,
	Shingo Nakao <shingo.x.nakao@sonymobile.com>,
	Milo Kim <milo.kim@ti.com>, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
Date: Fri, 26 Jul 2013 08:45:41 +0000	[thread overview]
Message-ID: <51F23735.5050806@ti.com> (raw)
In-Reply-To: <1372767354-16499-1-git-send-email-oskar.andero@sonymobile.com>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On 02/07/13 15:15, Oskar Andero wrote:
> From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> 
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
> 
> Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
> ---
>  drivers/video/backlight/lp855x_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
>  {
>  	struct lp855x *lp = bl_get_data(bl);
>  
> -	if (bl->props.state & BL_CORE_SUSPENDED)
> +	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
>  		bl->props.brightness = 0;
>  
>  	if (lp->mode == PWM_BASED) {
> 

Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Radovan Lekanovic <Radovan.Lekanovic@sonymobile.com>,
	Shingo Nakao <shingo.x.nakao@sonymobile.com>,
	Milo Kim <milo.kim@ti.com>, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] backlight: lp855x: set zero brightness at FBBLANK
Date: Fri, 26 Jul 2013 11:45:41 +0300	[thread overview]
Message-ID: <51F23735.5050806@ti.com> (raw)
In-Reply-To: <1372767354-16499-1-git-send-email-oskar.andero@sonymobile.com>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On 02/07/13 15:15, Oskar Andero wrote:
> From: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> 
> When backlight turns on early from display, a white line can be
> seen on the screen. Therefore make sure backlight is off when we
> are under an fb blank event.
> 
> Signed-off-by: Shingo Nakao <shingo.x.nakao@sonymobile.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
> ---
>  drivers/video/backlight/lp855x_bl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index a0e1e02..c0b41f1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
>  {
>  	struct lp855x *lp = bl_get_data(bl);
>  
> -	if (bl->props.state & BL_CORE_SUSPENDED)
> +	if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK))
>  		bl->props.brightness = 0;
>  
>  	if (lp->mode == PWM_BASED) {
> 

Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  parent reply	other threads:[~2013-07-26  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 12:15 [PATCH] backlight: lp855x: set zero brightness at FBBLANK Oskar Andero
2013-07-02 12:15 ` Oskar Andero
2013-07-02 23:24 ` Kim, Milo
2013-07-02 23:24   ` Kim, Milo
2013-07-03  1:52 ` Jingoo Han
2013-07-03  1:52   ` Jingoo Han
2013-07-26  8:45 ` Tomi Valkeinen [this message]
2013-07-26  8:45   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F23735.5050806@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=Radovan.Lekanovic@sonymobile.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milo.kim@ti.com \
    --cc=oskar.andero@sonymobile.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=rpurdie@rpsys.net \
    --cc=shingo.x.nakao@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.