* [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
@ 2013-07-26 23:46 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-07-26 23:46 UTC (permalink / raw)
To: linux-arm-kernel
The following message is printed on the BOCK-W kernel bootup:
sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
In addition, SD card cannot be detected. The reason is apparently that commit
ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
add SDHI support).
Add the missing pin groups according to the BOCK-W board schematics.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
arch/arm/mach-shmobile/board-bockw.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Index: renesas/arch/arm/mach-shmobile/board-bockw.c
=================================--- renesas.orig/arch/arm/mach-shmobile/board-bockw.c
+++ renesas/arch/arm/mach-shmobile/board-bockw.c
@@ -167,7 +167,13 @@ static const struct pinctrl_map bockw_pi
"usb1", "usb1"),
/* SDHI0 */
PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
- "sdhi0", "sdhi0"),
+ "sdhi0_data4", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_ctrl", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_cd", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_wp", "sdhi0"),
};
#define FPGA 0x18200000
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
@ 2013-07-26 23:46 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-07-26 23:46 UTC (permalink / raw)
To: linux-arm-kernel
The following message is printed on the BOCK-W kernel bootup:
sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
In addition, SD card cannot be detected. The reason is apparently that commit
ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
add SDHI support).
Add the missing pin groups according to the BOCK-W board schematics.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
arch/arm/mach-shmobile/board-bockw.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Index: renesas/arch/arm/mach-shmobile/board-bockw.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-bockw.c
+++ renesas/arch/arm/mach-shmobile/board-bockw.c
@@ -167,7 +167,13 @@ static const struct pinctrl_map bockw_pi
"usb1", "usb1"),
/* SDHI0 */
PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
- "sdhi0", "sdhi0"),
+ "sdhi0_data4", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_ctrl", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_cd", "sdhi0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7778",
+ "sdhi0_wp", "sdhi0"),
};
#define FPGA 0x18200000
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
2013-07-26 23:46 ` Sergei Shtylyov
@ 2013-07-26 23:55 ` Sergei Shtylyov
-1 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-07-26 23:55 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 07/27/2013 03:46 AM, Sergei Shtylyov wrote:
> The following message is printed on the BOCK-W kernel bootup:
> sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
> In addition, SD card cannot be detected. The reason is apparently that commit
> ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> add SDHI support).
> Add the missing pin groups according to the BOCK-W board schematics.
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
It also applies to the current Linus' tree cleanly. Please push it for 3.11.
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
@ 2013-07-26 23:55 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-07-26 23:55 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 07/27/2013 03:46 AM, Sergei Shtylyov wrote:
> The following message is printed on the BOCK-W kernel bootup:
> sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
> In addition, SD card cannot be detected. The reason is apparently that commit
> ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> add SDHI support).
> Add the missing pin groups according to the BOCK-W board schematics.
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
> The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
It also applies to the current Linus' tree cleanly. Please push it for 3.11.
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
2013-07-26 23:55 ` Sergei Shtylyov
@ 2013-07-29 0:20 ` Kuninori Morimoto
-1 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2013-07-29 0:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon
> > The following message is printed on the BOCK-W kernel bootup:
>
> > sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
>
> > In addition, SD card cannot be detected. The reason is apparently that commit
> > ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> > the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> > add SDHI support).
>
> > Add the missing pin groups according to the BOCK-W board schematics.
>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> > ---
> > The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
>
> It also applies to the current Linus' tree cleanly. Please push it for 3.11.
>
> WBR, Sergei
Something happen on patch.
Linux/master branch seems have old verion.
---- linux/master : old version --------------------------
commit ca7bb309485e4ec89a9addd47beaa1d079841b7d
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Wed Apr 17 05:17:56 2013 +0000
ARM: shmobile: bockw: add SDHI0 support
This patch is directly accessing to PUPR4 register which can
control SDHI0 CD/WP pin pull-up setting.
It should be replaced in the future.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
----------------------------------------------------------
This is the correct/latest version
----- correct version ---------------------------------------------
commit c2ee46ab49ce3bb5a60b36940e70355beb409acf
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Thu Apr 18 20:09:32 2013 -0700
ARM: shmobile: bockw: add SDHI0 support
This patch is directly accessing to PUPR4 register which can
control SDHI0 CD/WP pin pull-up setting.
It should be replaced in the future.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
-------------------------------------------------------------------
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
@ 2013-07-29 0:20 ` Kuninori Morimoto
0 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2013-07-29 0:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon
> > The following message is printed on the BOCK-W kernel bootup:
>
> > sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
>
> > In addition, SD card cannot be detected. The reason is apparently that commit
> > ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> > the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> > add SDHI support).
>
> > Add the missing pin groups according to the BOCK-W board schematics.
>
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> > ---
> > The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
>
> It also applies to the current Linus' tree cleanly. Please push it for 3.11.
>
> WBR, Sergei
Something happen on patch.
Linux/master branch seems have old verion.
---- linux/master : old version --------------------------
commit ca7bb309485e4ec89a9addd47beaa1d079841b7d
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Wed Apr 17 05:17:56 2013 +0000
ARM: shmobile: bockw: add SDHI0 support
This patch is directly accessing to PUPR4 register which can
control SDHI0 CD/WP pin pull-up setting.
It should be replaced in the future.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
----------------------------------------------------------
This is the correct/latest version
----- correct version ---------------------------------------------
commit c2ee46ab49ce3bb5a60b36940e70355beb409acf
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Thu Apr 18 20:09:32 2013 -0700
ARM: shmobile: bockw: add SDHI0 support
This patch is directly accessing to PUPR4 register which can
control SDHI0 CD/WP pin pull-up setting.
It should be replaced in the future.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
-------------------------------------------------------------------
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
2013-07-29 0:20 ` Kuninori Morimoto
@ 2013-07-30 2:15 ` Simon Horman
-1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-07-30 2:15 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jul 28, 2013 at 05:20:43PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > The following message is printed on the BOCK-W kernel bootup:
> >
> > > sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
> >
> > > In addition, SD card cannot be detected. The reason is apparently that commit
> > > ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> > > the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> > > add SDHI support).
> >
> > > Add the missing pin groups according to the BOCK-W board schematics.
> >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > > ---
> > > The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
> >
> > It also applies to the current Linus' tree cleanly. Please push it for 3.11.
> >
> > WBR, Sergei
>
> Something happen on patch.
That something was probably me :(
> Linux/master branch seems have old verion.
>
> ---- linux/master : old version --------------------------
> commit ca7bb309485e4ec89a9addd47beaa1d079841b7d
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Wed Apr 17 05:17:56 2013 +0000
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ----------------------------------------------------------
>
> This is the correct/latest version
>
> ----- correct version ---------------------------------------------
> commit c2ee46ab49ce3bb5a60b36940e70355beb409acf
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Thu Apr 18 20:09:32 2013 -0700
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> -------------------------------------------------------------------
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, I have queued this up for v3.11 in the fixes-for-v3.11 branch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
@ 2013-07-30 2:15 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-07-30 2:15 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jul 28, 2013 at 05:20:43PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > The following message is printed on the BOCK-W kernel bootup:
> >
> > > sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
> >
> > > In addition, SD card cannot be detected. The reason is apparently that commit
> > > ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> > > the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> > > add SDHI support).
> >
> > > Add the missing pin groups according to the BOCK-W board schematics.
> >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > > ---
> > > The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
> >
> > It also applies to the current Linus' tree cleanly. Please push it for 3.11.
> >
> > WBR, Sergei
>
> Something happen on patch.
That something was probably me :(
> Linux/master branch seems have old verion.
>
> ---- linux/master : old version --------------------------
> commit ca7bb309485e4ec89a9addd47beaa1d079841b7d
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Wed Apr 17 05:17:56 2013 +0000
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ----------------------------------------------------------
>
> This is the correct/latest version
>
> ----- correct version ---------------------------------------------
> commit c2ee46ab49ce3bb5a60b36940e70355beb409acf
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Thu Apr 18 20:09:32 2013 -0700
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> -------------------------------------------------------------------
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, I have queued this up for v3.11 in the fixes-for-v3.11 branch.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-30 2:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-26 23:46 [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings Sergei Shtylyov
2013-07-26 23:46 ` Sergei Shtylyov
2013-07-26 23:55 ` Sergei Shtylyov
2013-07-26 23:55 ` Sergei Shtylyov
2013-07-29 0:20 ` Kuninori Morimoto
2013-07-29 0:20 ` Kuninori Morimoto
2013-07-30 2:15 ` Simon Horman
2013-07-30 2:15 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.