From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'Tomi Valkeinen' <tomi.valkeinen@ti.com>,
'Jean-Christophe Plagniol-Villard' <plagnioj@jcrosoft.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
guohanjun@huawei.com,
'Luis Henriques' <luis.henriques@canonical.com>
Subject: Re: [PATCH] video: remove unused variable dev
Date: Mon, 29 Jul 2013 01:27:32 +0000 [thread overview]
Message-ID: <51F5C504.6040504@huawei.com> (raw)
In-Reply-To: <009601ce8bf5$e88bfda0$b9a3f8e0$@samsung.com>
On 07/29 8:52, Jingoo Han wrote:
> On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
>>
>> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
>> variable dev is unused, so remove it.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> drivers/video/vga16fb.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> CC'ed Luis Henriques.
>
>
> Hi Kefeng Wang,
>
> The same patch was submitted by Luis Henriques 2 weeks ago.
> Also, the patch was already applied by Tomi Valkeinen.
>
> Best regards,
> Jingoo Han
>
Thanks for your reply, I got it, so ignore it.
>>
>> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
>> index 830ded4..2827333 100644
>> --- a/drivers/video/vga16fb.c
>> +++ b/drivers/video/vga16fb.c
>> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>>
>> static void vga16fb_destroy(struct fb_info *info)
>> {
>> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>> iounmap(info->screen_base);
>> fb_dealloc_cmap(&info->cmap);
>> /* XXX unshare VGA regions */
>> --
>> 1.8.2.2
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Tomi Valkeinen'" <tomi.valkeinen@ti.com>,
"'Jean-Christophe Plagniol-Villard'" <plagnioj@jcrosoft.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<guohanjun@huawei.com>,
"'Luis Henriques'" <luis.henriques@canonical.com>
Subject: Re: [PATCH] video: remove unused variable dev
Date: Mon, 29 Jul 2013 09:27:32 +0800 [thread overview]
Message-ID: <51F5C504.6040504@huawei.com> (raw)
In-Reply-To: <009601ce8bf5$e88bfda0$b9a3f8e0$@samsung.com>
On 07/29 8:52, Jingoo Han wrote:
> On Saturday, July 27, 2013 7:05 PM, Kefeng Wang wrote:
>>
>> Due to commit: e21d2170f [video: remove unnecessary platform_set_drvdata()],
>> variable dev is unused, so remove it.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> drivers/video/vga16fb.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> CC'ed Luis Henriques.
>
>
> Hi Kefeng Wang,
>
> The same patch was submitted by Luis Henriques 2 weeks ago.
> Also, the patch was already applied by Tomi Valkeinen.
>
> Best regards,
> Jingoo Han
>
Thanks for your reply, I got it, so ignore it.
>>
>> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
>> index 830ded4..2827333 100644
>> --- a/drivers/video/vga16fb.c
>> +++ b/drivers/video/vga16fb.c
>> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>>
>> static void vga16fb_destroy(struct fb_info *info)
>> {
>> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
>> iounmap(info->screen_base);
>> fb_dealloc_cmap(&info->cmap);
>> /* XXX unshare VGA regions */
>> --
>> 1.8.2.2
>
>
>
>
next prev parent reply other threads:[~2013-07-29 1:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 10:05 [PATCH] video: remove unused variable dev Kefeng Wang
2013-07-27 10:05 ` Kefeng Wang
2013-07-29 0:52 ` Jingoo Han
2013-07-29 0:52 ` Jingoo Han
2013-07-29 1:27 ` Kefeng Wang [this message]
2013-07-29 1:27 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F5C504.6040504@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jg1.han@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.henriques@canonical.com \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.