From: "Vadim A. Misbakh-Soloviov" <mva@mva.name>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] Fixed flask policy's install path to avoid installing it as '/boot' file
Date: Mon, 29 Jul 2013 21:20:59 +0400 [thread overview]
Message-ID: <51F6A47B.8060301@mva.name> (raw)
In-Reply-To: <51F6A3FB.3080001@tycho.nsa.gov>
[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]
Okay, thanks.
So, Can I just ammend commits and resend both patches again? :)
29.07.2013 21:18, Daniel De Graaf пишет:
> On 07/29/2013 01:01 PM, Vadim A. Misbakh-Soloviov wrote:
>> From: "Vadim A. Misbakh-Soloviov" <mva@mva.name>
>>
>> Signed-off-by: Vadim A. Misbakh-Soloviov <mva@mva.name>
>> ---
>> tools/flask/policy/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile
>> index e666f3e..d917231 100644
>> --- a/tools/flask/policy/Makefile
>> +++ b/tools/flask/policy/Makefile
>> @@ -103,6 +103,7 @@ POLICY_SECTIONS += $(USERS) $(CONSTRAINTS)
>> $(ISID_DEFS)
>> all: $(POLICY_FILENAME)
>>
>> install: $(POLICY_FILENAME)
>> + $(INSTALL_DIR) $(DESTDIR)$(POLICY_LOADPATH)
>> $(INSTALL_DATA) $^ $(POLICY_LOADPATH)
>>
>> $(POLICY_FILENAME): policy.conf
>>
>
> POLICY_LOADPATH is defined as $(DESTDIR)/boot, so this expands to:
> $(INSTALL_DIR) $(DESTDIR)$(DESTDIR)/boot
>
> I believe the correct fix is to instead add:
> $(INSTALL_DIR) $(POLICY_LOADPATH)
>
> With that change, this patch is
>
> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>
> Patch 2/2 looks correct as-is or with Andrew's cleanup.
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-07-29 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 17:01 [PATCH 1/2] Fixed flask policy's install path to avoid installing it as '/boot' file Vadim A. Misbakh-Soloviov
2013-07-29 17:01 ` [PATCH 2/2] Fixed xen-tools makefile to build flask-tools and flask policy only if flask build especially enabled Vadim A. Misbakh-Soloviov
2013-07-29 17:09 ` Andrew Cooper
2013-07-29 17:18 ` [PATCH 1/2] Fixed flask policy's install path to avoid installing it as '/boot' file Daniel De Graaf
2013-07-29 17:20 ` Vadim A. Misbakh-Soloviov [this message]
2013-07-30 9:51 ` Ian Campbell
2013-07-30 11:35 ` Vadim A. Misbakh-Soloviov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F6A47B.8060301@mva.name \
--to=mva@mva.name \
--cc=Ian.Campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.