From: "Andreas Färber" <afaerber@suse.de>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, stefanha@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState
Date: Tue, 30 Jul 2013 14:16:08 +0200 [thread overview]
Message-ID: <51F7AE88.5040204@suse.de> (raw)
In-Reply-To: <1375170777-31457-4-git-send-email-famz@redhat.com>
Am 30.07.2013 09:52, schrieb Fam Zheng:
> Introduce bdrv_ref/bdrv_unref to manage the lifecycle of
> BlockDriverState. They are unused for now but will used to replace
> bdrv_delete() later.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 22 ++++++++++++++++++++++
> include/block/block.h | 2 ++
> include/block/block_int.h | 1 +
> 3 files changed, 25 insertions(+)
Didn't Kevin and Markus look into turning BlockDriverState into QOM
objects a while back? That would give you reference counting for free,
even atomic unlike this patch.
MemoryRegion resorted to reference counting on the owner object that was
added for the purpose.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-30 12:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:52 [Qemu-devel] [PATCH v2 0/7] Implement reference count for BlockDriverState Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 1/7] vvfat: use bdrv_new() to allocate BlockDriverState Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 2/7] iscsi: use bdrv_new() instead of stack structure Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState Fam Zheng
2013-07-30 12:16 ` Andreas Färber [this message]
2013-07-30 14:50 ` Stefan Hajnoczi
2013-07-30 14:51 ` Jeff Cody
2013-07-30 14:58 ` Stefan Hajnoczi
2013-07-31 9:51 ` Fam Zheng
2013-08-01 9:30 ` Stefan Hajnoczi
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 4/7] block: make bdrv_delete() static Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 5/7] migration: omit drive ref as we have bdrv_ref now Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 6/7] xen_disk: simplify blk_disconnect with refcnt Fam Zheng
2013-07-30 7:52 ` [Qemu-devel] [PATCH v2 7/7] nbd: use BlockDriverState refcnt Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7AE88.5040204@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.