From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI
Date: Tue, 30 Jul 2013 23:07:21 +0400 [thread overview]
Message-ID: <51F80EE9.30801@cogentembedded.com> (raw)
In-Reply-To: <1375196394-21138-9-git-send-email-maxime.ripard@free-electrons.com>
Hello.
On 07/30/2013 06:59 PM, Maxime Ripard wrote:
> The UARTs on the A20 can be muxed to several pins. Add a few options to
> the DTSI so that we can start using them in the boards' DT.
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 704fca9..9f45e8d 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -70,6 +70,27 @@
> #address-cells = <1>;
> #size-cells = <0>;
> #gpio-cells = <3>;
> +
> + uart0_pins_a: uart0 at 0 {
Why have address part of the node name if there's not "reg" property?
And the preferred node name is "serial", not "uart", according to the ePAPR
spec (http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf).
> + allwinner,pins = "PB22", "PB23";
> + allwinner,function = "uart0";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart6_pins_a: uart6 at 0 {
> + allwinner,pins = "PI12", "PI13";
> + allwinner,function = "uart6";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart7_pins_a: uart7 at 0 {
> + allwinner,pins = "PI20", "PI21";
> + allwinner,function = "uart7";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org,
Emilio Lopez <emilio@elopez.com.ar>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com
Subject: Re: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI
Date: Tue, 30 Jul 2013 23:07:21 +0400 [thread overview]
Message-ID: <51F80EE9.30801@cogentembedded.com> (raw)
In-Reply-To: <1375196394-21138-9-git-send-email-maxime.ripard@free-electrons.com>
Hello.
On 07/30/2013 06:59 PM, Maxime Ripard wrote:
> The UARTs on the A20 can be muxed to several pins. Add a few options to
> the DTSI so that we can start using them in the boards' DT.
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 704fca9..9f45e8d 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -70,6 +70,27 @@
> #address-cells = <1>;
> #size-cells = <0>;
> #gpio-cells = <3>;
> +
> + uart0_pins_a: uart0@0 {
Why have address part of the node name if there's not "reg" property?
And the preferred node name is "serial", not "uart", according to the ePAPR
spec (http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf).
> + allwinner,pins = "PB22", "PB23";
> + allwinner,function = "uart0";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart6_pins_a: uart6@0 {
> + allwinner,pins = "PI12", "PI13";
> + allwinner,function = "uart6";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart7_pins_a: uart7@0 {
> + allwinner,pins = "PI20", "PI21";
> + allwinner,function = "uart7";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
WBR, Sergei
next prev parent reply other threads:[~2013-07-30 19:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 14:59 [PATCH 00/10] Introduce Allwinner A20 support Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 01/10] ARM: sunxi: " Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 02/10] ARM: sun7i: Add Allwinner A20 DTSI Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 03/10] ARM: sun7i: Add Olimex A20-Olinuxino-Micro support Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 04/10] pinctrl: sunxi: Wrap long compatible declaration lines Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 15:09 ` [linux-sunxi] " Ian Campbell
2013-07-30 15:09 ` Ian Campbell
2013-07-30 20:31 ` Maxime Ripard
2013-07-30 20:31 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 05/10] pinctrl: sunxi: Add Allwinner A20 pins set Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 06/10] pinctrl: sunxi: Fix inconsistent indentation Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 07/10] ARM: sun7i: Add the PIO controller node to the DTSI Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options " Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 19:07 ` Sergei Shtylyov [this message]
2013-07-30 19:07 ` Sergei Shtylyov
2013-07-30 20:10 ` Maxime Ripard
2013-07-30 20:10 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 09/10] ARM: sun7i: a20-olinuxino: Enable UARTs muxing Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
2013-07-30 14:59 ` [PATCH 10/10] ARM: sun7i: a20-olinuxino: Enable the user LED Maxime Ripard
2013-07-30 14:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F80EE9.30801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.