From: Qiang Huang <h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Sha Zhengju <handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>,
Daisuke Nishimura
<nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Jeff Liu <jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 0/4] memcg: fix memcg resource limit overflow issues
Date: Wed, 31 Jul 2013 17:51:01 +0800 [thread overview]
Message-ID: <51F8DE05.5020606@huawei.com> (raw)
In-Reply-To: <CAFj3OHUEVM+BtoYS8wbXRU42Q8_=1X5qaQm7QY8oBc=ONAdfOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2013/7/31 17:39, Sha Zhengju wrote:
> On Wed, Jul 31, 2013 at 4:54 PM, Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>> On 2013/7/31 16:51, Qiang Huang wrote:
>>> On 2013/7/31 16:23, Sha Zhengju wrote:
>>>> Hi list,
>>>>
>>>> On Wed, Jul 31, 2013 at 3:31 PM, Qiang Huang <h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>>>>> This issue is first discussed in:
>>>>> http://marc.info/?l=linux-mm&m=136574878704295&w=2
>>>>>
>>>>> Then a second version sent to:
>>>>> http://marc.info/?l=linux-mm&m=136776855928310&w=2
>>>>>
>>>>> We contacted Sha a month ago, she seems have no time to deal with it
>>>>> recently, but we quite need this patch. So I modified and resent it.
>>>>
>>>>
>>>> No, I didn't receive any of YOUR message, only a engineer named Libo
>>>> Chen from Huawei connected me recently. I don't approve you to resent
>>>> them on behalf of me, and just before you send this you even don't
>>>> send me a mail. Besides, after a rough look, I do not see any
>>>> innovative ideas from yourself but just rework patches from my last
>>>> version.
>>>> So I'm strong against this patchset.
>>>
>>> Sorry if this troubles you.
>>> Libo Chen is my colleague, we work together, he sent an email to you on
>>> 25 June, to ask about this issue, you said you'll resent it soon, but it
>>> didn't happen until now :(, and he asked again the other day and you didn't
>>> reply. As we really need to fix this problem(and need it in upstream), so
>>> I modified it and sent out.
>>>
>>> I think split patches, rewrite changelogs and tests, they all kind of work
>>> right? Of course, if you mind, I can change it, I just need this fix merged
>>> to upstream ASAP.
>>>
>>> So you want me rewrite this patchset and SOB only you or you want resent this
>>> by yourself? I'm ok with both :)
>>>
>>
>> No, you can't send out patches without your SOB...but you can add a line
>> in the beginning of the email:
>>
>> From: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
>>
>
> Cooperation is welcomed and I just hated this kind of behavior. I
> don't want to block the community, since they're urgent to the patches
> and Michal has already reviewed them just now, I won't be so caustic
> on it. I'm OK of letting the codes in under the rules of community.
>
OK, thank you Sha, I just confirmed again, Libo did get your reply, we
made a mistake, sorry for that.
It is my fault didn't get your permission before the rework, I didn't notice
this is that big deal, I'll be more careful next time :). Thanks again.
WARNING: multiple messages have this Message-ID (diff)
From: Qiang Huang <h.huangqiang@huawei.com>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: Li Zefan <lizefan@huawei.com>, Cgroups <cgroups@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Sha Zhengju <handai.szj@taobao.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>, Jeff Liu <jeff.liu@oracle.com>
Subject: Re: [PATCH 0/4] memcg: fix memcg resource limit overflow issues
Date: Wed, 31 Jul 2013 17:51:01 +0800 [thread overview]
Message-ID: <51F8DE05.5020606@huawei.com> (raw)
In-Reply-To: <CAFj3OHUEVM+BtoYS8wbXRU42Q8_=1X5qaQm7QY8oBc=ONAdfOA@mail.gmail.com>
On 2013/7/31 17:39, Sha Zhengju wrote:
> On Wed, Jul 31, 2013 at 4:54 PM, Li Zefan <lizefan@huawei.com> wrote:
>> On 2013/7/31 16:51, Qiang Huang wrote:
>>> On 2013/7/31 16:23, Sha Zhengju wrote:
>>>> Hi list,
>>>>
>>>> On Wed, Jul 31, 2013 at 3:31 PM, Qiang Huang <h.huangqiang@huawei.com> wrote:
>>>>> This issue is first discussed in:
>>>>> http://marc.info/?l=linux-mm&m=136574878704295&w=2
>>>>>
>>>>> Then a second version sent to:
>>>>> http://marc.info/?l=linux-mm&m=136776855928310&w=2
>>>>>
>>>>> We contacted Sha a month ago, she seems have no time to deal with it
>>>>> recently, but we quite need this patch. So I modified and resent it.
>>>>
>>>>
>>>> No, I didn't receive any of YOUR message, only a engineer named Libo
>>>> Chen from Huawei connected me recently. I don't approve you to resent
>>>> them on behalf of me, and just before you send this you even don't
>>>> send me a mail. Besides, after a rough look, I do not see any
>>>> innovative ideas from yourself but just rework patches from my last
>>>> version.
>>>> So I'm strong against this patchset.
>>>
>>> Sorry if this troubles you.
>>> Libo Chen is my colleague, we work together, he sent an email to you on
>>> 25 June, to ask about this issue, you said you'll resent it soon, but it
>>> didn't happen until now :(, and he asked again the other day and you didn't
>>> reply. As we really need to fix this problem(and need it in upstream), so
>>> I modified it and sent out.
>>>
>>> I think split patches, rewrite changelogs and tests, they all kind of work
>>> right? Of course, if you mind, I can change it, I just need this fix merged
>>> to upstream ASAP.
>>>
>>> So you want me rewrite this patchset and SOB only you or you want resent this
>>> by yourself? I'm ok with both :)
>>>
>>
>> No, you can't send out patches without your SOB...but you can add a line
>> in the beginning of the email:
>>
>> From: Sha Zhengju <handai.szj@taobao.com>
>>
>
> Cooperation is welcomed and I just hated this kind of behavior. I
> don't want to block the community, since they're urgent to the patches
> and Michal has already reviewed them just now, I won't be so caustic
> on it. I'm OK of letting the codes in under the rules of community.
>
OK, thank you Sha, I just confirmed again, Libo did get your reply, we
made a mistake, sorry for that.
It is my fault didn't get your permission before the rework, I didn't notice
this is that big deal, I'll be more careful next time :). Thanks again.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-07-31 9:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 7:31 [PATCH 0/4] memcg: fix memcg resource limit overflow issues Qiang Huang
2013-07-31 7:31 ` Qiang Huang
[not found] ` <1375255885-10648-1-git-send-email-h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 7:31 ` [PATCH 1/4] memcg: correct RESOURCE_MAX to ULLONG_MAX Qiang Huang
2013-07-31 7:31 ` Qiang Huang
[not found] ` <1375255885-10648-2-git-send-email-h.huangqiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 8:00 ` Michal Hocko
2013-07-31 8:00 ` Michal Hocko
2013-07-31 7:31 ` [PATCH 2/4] memcg: rename RESOURCE_MAX to RES_COUNTER_MAX Qiang Huang
2013-07-31 7:31 ` Qiang Huang
2013-07-31 8:02 ` Michal Hocko
2013-07-31 7:31 ` [PATCH 3/4] memcg: avoid overflow caused by PAGE_ALIGN Qiang Huang
2013-07-31 7:31 ` Qiang Huang
2013-07-31 8:14 ` Michal Hocko
2013-07-31 7:31 ` [PATCH 4/4] memcg: reduce function dereference Qiang Huang
2013-07-31 7:31 ` Qiang Huang
2013-07-31 8:20 ` Michal Hocko
2013-07-31 8:23 ` [PATCH 0/4] memcg: fix memcg resource limit overflow issues Sha Zhengju
2013-07-31 8:23 ` Sha Zhengju
[not found] ` <CAFj3OHX4WLaecyE_zFbnFKs9wrCWTq2eDAUDMxqPg8=TYt18gg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-31 8:51 ` Qiang Huang
2013-07-31 8:51 ` Qiang Huang
[not found] ` <51F8D016.4090009-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 8:54 ` Li Zefan
2013-07-31 8:54 ` Li Zefan
[not found] ` <51F8D0E1.4010007-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-31 9:02 ` Qiang Huang
2013-07-31 9:02 ` Qiang Huang
2013-07-31 9:34 ` Jeff Liu
2013-07-31 9:51 ` Li Zefan
2013-07-31 9:39 ` Sha Zhengju
2013-07-31 9:50 ` Michal Hocko
[not found] ` <20130731095010.GA5012-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2013-07-31 10:04 ` Sha Zhengju
2013-07-31 10:04 ` Sha Zhengju
[not found] ` <CAFj3OHUEVM+BtoYS8wbXRU42Q8_=1X5qaQm7QY8oBc=ONAdfOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-31 9:51 ` Qiang Huang [this message]
2013-07-31 9:51 ` Qiang Huang
2013-07-31 9:28 ` Sha Zhengju
2013-07-31 9:28 ` Sha Zhengju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8DE05.5020606@huawei.com \
--to=h.huangqiang-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org \
--cc=handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=nishimura-YQH0OdQVrdy45+QrQBaojngSJqDPrsil@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.