* [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_xattr_get_clusters
@ 2013-07-31 9:33 Joseph Qi
2013-07-31 9:57 ` Jeff Liu
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Qi @ 2013-07-31 9:33 UTC (permalink / raw)
To: ocfs2-devel
In ocfs2_xattr_value_attach_refcount(), if error occurs when calling
ocfs2_xattr_get_clusters(), it will go with unexpected behavior since
local variables p_cluster, num_clusters and ext_flags are declared
without initialization.
Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
---
fs/ocfs2/xattr.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 2e3ea30..87daa44 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -5889,6 +5889,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode,
while (cpos < clusters) {
ret = ocfs2_xattr_get_clusters(inode, cpos, &p_cluster,
&num_clusters, el, &ext_flags);
+ if (ret) {
+ mlog_errno(ret);
+ break;
+ }
cpos += num_clusters;
if ((ext_flags & OCFS2_EXT_REFCOUNTED))
--
1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_xattr_get_clusters
2013-07-31 9:33 [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_xattr_get_clusters Joseph Qi
@ 2013-07-31 9:57 ` Jeff Liu
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Liu @ 2013-07-31 9:57 UTC (permalink / raw)
To: ocfs2-devel
On 07/31/2013 05:33 PM, Joseph Qi wrote:
> In ocfs2_xattr_value_attach_refcount(), if error occurs when calling
> ocfs2_xattr_get_clusters(), it will go with unexpected behavior since
> local variables p_cluster, num_clusters and ext_flags are declared
> without initialization.
>
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Looks good, thanks!
Acked-by: Jie Liu <jeff.liu@oracle.com>
> ---
> fs/ocfs2/xattr.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
> index 2e3ea30..87daa44 100644
> --- a/fs/ocfs2/xattr.c
> +++ b/fs/ocfs2/xattr.c
> @@ -5889,6 +5889,10 @@ static int ocfs2_xattr_value_attach_refcount(struct inode *inode,
> while (cpos < clusters) {
> ret = ocfs2_xattr_get_clusters(inode, cpos, &p_cluster,
> &num_clusters, el, &ext_flags);
> + if (ret) {
> + mlog_errno(ret);
> + break;
> + }
>
> cpos += num_clusters;
> if ((ext_flags & OCFS2_EXT_REFCOUNTED))
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 9:33 [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_xattr_get_clusters Joseph Qi
2013-07-31 9:57 ` Jeff Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.