From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd.bergmann@linaro.org
Subject: Re: [PATCH 08/15] cpufreq: omap: initialize .owner field with THIS_MODULE
Date: Wed, 31 Jul 2013 10:22:51 -0400 [thread overview]
Message-ID: <51F91DBB.6010400@ti.com> (raw)
In-Reply-To: <2274a4c250c83058b5b2df75f33e47fe1422036a.1375279948.git.viresh.kumar@linaro.org>
On Wednesday 31 July 2013 10:19 AM, Viresh Kumar wrote:
> CPUFreq core does following at multiple places:
> module_{get|put}(cpufreq_driver->owner)).
>
> This is done to make sure module doesn't get unloaded if it is currently in use.
> This will work only if the .owner field of cpufreq driver is initialized with a
> valid pointer.
>
> This field wasn't initialized for this driver, lets initialize it with
> THIS_MODULE.
>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Looks fine.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rjw@sisk.pl>, <linaro-kernel@lists.linaro.org>,
<patches@linaro.org>, <cpufreq@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arnd.bergmann@linaro.org>
Subject: Re: [PATCH 08/15] cpufreq: omap: initialize .owner field with THIS_MODULE
Date: Wed, 31 Jul 2013 10:22:51 -0400 [thread overview]
Message-ID: <51F91DBB.6010400@ti.com> (raw)
In-Reply-To: <2274a4c250c83058b5b2df75f33e47fe1422036a.1375279948.git.viresh.kumar@linaro.org>
On Wednesday 31 July 2013 10:19 AM, Viresh Kumar wrote:
> CPUFreq core does following at multiple places:
> module_{get|put}(cpufreq_driver->owner)).
>
> This is done to make sure module doesn't get unloaded if it is currently in use.
> This will work only if the .owner field of cpufreq driver is initialized with a
> valid pointer.
>
> This field wasn't initialized for this driver, lets initialize it with
> THIS_MODULE.
>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Looks fine.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-07-31 14:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 14:19 [PATCH 00/15] cpufreq: initialize drivers .owner field with THIS_MODULE Viresh Kumar
2013-07-31 14:19 ` [PATCH 01/15] cpufreq: arm_big_little: initialize " Viresh Kumar
2013-07-31 14:19 ` [PATCH 02/15] cpufreq: cpufreq-cpu0: " Viresh Kumar
2013-08-04 11:38 ` Shawn Guo
2013-08-04 11:38 ` Shawn Guo
2013-07-31 14:19 ` [PATCH 03/15] cpufreq: davinci: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 04/15] cpufreq: dbx500: " Viresh Kumar
2013-08-14 16:43 ` Linus Walleij
2013-07-31 14:19 ` [PATCH 05/15] cpufreq: exynos: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 06/15] cpufreq: imx6q: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 07/15] cpufreq: integrator: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 08/15] cpufreq: omap: " Viresh Kumar
2013-07-31 14:22 ` Santosh Shilimkar [this message]
2013-07-31 14:22 ` Santosh Shilimkar
2013-07-31 14:19 ` [PATCH 09/15] cpufreq: pxa: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 10/15] cpufreq: s3c24xx: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 11/15] cpufreq: s5pv210: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 12/15] cpufreq: sa11**: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 13/15] cpufreq: SPEAr: " Viresh Kumar
2013-07-31 14:19 ` [PATCH 14/15] cpufreq: Tegra: " Viresh Kumar
2013-07-31 19:13 ` Stephen Warren
2013-07-31 21:10 ` Rafael J. Wysocki
2013-07-31 14:19 ` [PATCH 15/15] cpufreq: Unicore: " Viresh Kumar
2013-07-31 16:36 ` [PATCH 00/15] cpufreq: initialize drivers " Sachin Kamat
2013-07-31 16:39 ` Viresh Kumar
2013-08-02 9:42 ` Sachin Kamat
2013-08-03 11:50 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F91DBB.6010400@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=arnd.bergmann@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.