From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Wed, 31 Jul 2013 18:14:07 +0000 [thread overview]
Message-ID: <51F953EF.5060107@free-electrons.com> (raw)
In-Reply-To: <002301ce8991$f9b82060$ed286120$@samsung.com>
Hi,
On 26/07/2013 01:52, Jingoo Han wrote:
> On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
>> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> Add support for the Himax HX8369 controller as it is quite similar to the
>> hx8357.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>> ---
>> drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 206 insertions(+), 15 deletions(-)
>>
> [....]
>
>> + ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
>> + if (ret < 0)
>> + return ret;
>> +
>> + msleep(100);
> Hi Maxime Ripard,
>
> Could you add comment on this huge delay, too?
That one can actually be removed.
Regards,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Wed, 31 Jul 2013 20:14:07 +0200 [thread overview]
Message-ID: <51F953EF.5060107@free-electrons.com> (raw)
In-Reply-To: <002301ce8991$f9b82060$ed286120$@samsung.com>
Hi,
On 26/07/2013 01:52, Jingoo Han wrote:
> On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
>> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> Add support for the Himax HX8369 controller as it is quite similar to the
>> hx8357.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>> ---
>> drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 206 insertions(+), 15 deletions(-)
>>
> [....]
>
>> + ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
>> + if (ret < 0)
>> + return ret;
>> +
>> + msleep(100);
> Hi Maxime Ripard,
>
> Could you add comment on this huge delay, too?
That one can actually be removed.
Regards,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Maxime Ripard'" <maxime.ripard@free-electrons.com>,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
hector.palacios@digi.com,
"'Thomas Petazzoni'" <thomas@free-electrons.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support
Date: Wed, 31 Jul 2013 20:14:07 +0200 [thread overview]
Message-ID: <51F953EF.5060107@free-electrons.com> (raw)
In-Reply-To: <002301ce8991$f9b82060$ed286120$@samsung.com>
Hi,
On 26/07/2013 01:52, Jingoo Han wrote:
> On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
>> From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> Add support for the Himax HX8369 controller as it is quite similar to the
>> hx8357.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Acked-by: Jingoo Han <jg1.han@samsung.com>
>> ---
>> drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
>> 1 file changed, 206 insertions(+), 15 deletions(-)
>>
> [....]
>
>> + ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
>> + if (ret < 0)
>> + return ret;
>> +
>> + msleep(100);
> Hi Maxime Ripard,
>
> Could you add comment on this huge delay, too?
That one can actually be removed.
Regards,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-31 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:05 [PATCHv2 0/3] Few ignored framebuffer fixes/additions Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` [PATCHv2 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` [PATCHv2 2/3] video: hx8357: Make IM pins optional Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 23:47 ` Jingoo Han
2013-07-25 23:47 ` Jingoo Han
2013-07-25 23:47 ` Jingoo Han
2013-07-25 13:05 ` [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 13:05 ` Maxime Ripard
2013-07-25 23:52 ` Jingoo Han
2013-07-25 23:52 ` Jingoo Han
2013-07-25 23:52 ` Jingoo Han
2013-07-31 18:14 ` Alexandre Belloni [this message]
2013-07-31 18:14 ` Alexandre Belloni
2013-07-31 18:14 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F953EF.5060107@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.