From: Nikolay Aleksandrov <nikolay@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, andy@greyhouse.net, davem@davemloft.net,
fubar@us.ibm.com
Subject: Re: [PATCH net-next 1/5] bonding: convert to list API and replace bond's custom list
Date: Wed, 31 Jul 2013 20:49:10 +0200 [thread overview]
Message-ID: <51F95C26.6090600@redhat.com> (raw)
In-Reply-To: <20130731113849.02746040@nehalam.linuxnetplumber.net>
On 07/31/2013 08:38 PM, Stephen Hemminger wrote:
> On Wed, 31 Jul 2013 17:12:29 +0200
> Nikolay Aleksandrov <nikolay@redhat.com> wrote:
>
>> - bond_for_each_slave(bond, tmp, i)
>> + list_for_each_entry(tmp, &bond->slave_list, list)
>
> It would be nice to keep the wrapper macro's bond_for_each_slave
> and introduce a bond_for_each_slave_rcu() for the cases where you
> are using RCU.
>
I had done it like that in the first versions of these patches but since
this patchset is changing parts that people have relied on for a long time
I'd prefer to keep the list_for_each_entry(_rcu) explicit at least in the
beginning so no one can get confused about what's happening or a person who
hasn't looked in the code recently would find it easier to get up to speed.
Also I don't think the full writing of list_for_each_entry has lead to
breaking any lines right now.
In the end I don't have strong feelings about how this should look, so
either way is fine with me, these are my arguments for doing it this way.
Nik
next prev parent reply other threads:[~2013-07-31 18:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 15:12 [PATCH net-next 0/5] bonding: groundwork and initial conversion to RCU Nikolay Aleksandrov
2013-07-31 15:12 ` [PATCH net-next 1/5] bonding: convert to list API and replace bond's custom list Nikolay Aleksandrov
2013-07-31 18:28 ` Jay Vosburgh
2013-07-31 18:42 ` Nikolay Aleksandrov
2013-07-31 18:37 ` Stephen Hemminger
2013-07-31 18:44 ` Nikolay Aleksandrov
2013-07-31 18:56 ` Stephen Hemminger
2013-07-31 19:00 ` Nikolay Aleksandrov
2013-07-31 18:38 ` Stephen Hemminger
2013-07-31 18:49 ` Nikolay Aleksandrov [this message]
2013-07-31 15:12 ` [PATCH net-next 2/5] bonding: remove unnecessary read_locks of curr_slave_lock Nikolay Aleksandrov
2013-07-31 15:12 ` [PATCH net-next 3/5] bonding: simplify broadcast_xmit function Nikolay Aleksandrov
2013-07-31 15:12 ` [PATCH net-next 4/5] bonding: factor out slave id tx code and simplify xmit paths Nikolay Aleksandrov
2013-07-31 15:12 ` [PATCH net-next 5/5] bonding: initial RCU conversion Nikolay Aleksandrov
2013-08-01 6:46 ` Ding Tianhong
2013-08-01 7:55 ` Nikolay Aleksandrov
2013-07-31 15:27 ` [PATCH net-next 0/5] bonding: groundwork and initial conversion to RCU Eric Dumazet
2013-07-31 15:39 ` Nikolay Aleksandrov
2013-07-31 18:03 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F95C26.6090600@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.