From: "Vadim A. Misbakh-Soloviov" <mva@mva.name>
To: xen-devel@lists.xen.org
Subject: Re: [Patch V3 3/3] Fixed policy Makefile with Ian Campbell advice:
Date: Wed, 31 Jul 2013 23:29:37 +0400 [thread overview]
Message-ID: <51F965A1.7090107@mva.name> (raw)
In-Reply-To: <1375190173.32691.6.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1922 bytes --]
Nice, that both of you agreed with patchset. But unfortunately I'm a
newbie in Xen development, so I don't know, what should I do now. Just
wait when someone commit it into staging? Or I should push it somewhere? :)
30.07.2013 17:16, Ian Campbell пишет:
> On Tue, 2013-07-30 at 16:34 +0400, Vadim A. Misbakh-Soloviov wrote:
>> From: "Vadim A. Misbakh-Soloviov" <mva@mva.name>
>>
>> 30.07.2013 13:51, Ian Campbell wrote:
>>> I think it would be a bit less surprising for drive by patchers etc to
>>> remove the DESTDIR from POLICY_LOADPATH and add it to the install
>>> target, which is the usual way to do things. Up to you/Vadim though.
>>
>> Signed-off-by: Vadim A. Misbakh-Soloviov <mva@mva.name>
>
> Looks good to me, I'll give Daniel a chance to object though.
>
> Ian.
>
>> ---
>> tools/flask/policy/Makefile | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/flask/policy/Makefile b/tools/flask/policy/Makefile
>> index df1e8f3..a1c0f11 100644
>> --- a/tools/flask/policy/Makefile
>> +++ b/tools/flask/policy/Makefile
>> @@ -33,7 +33,7 @@ M4 ?= m4
>> OUTPUT_POLICY = 24
>>
>> POLICY_FILENAME = xenpolicy.$(OUTPUT_POLICY)
>> -POLICY_LOADPATH = $(DESTDIR)/boot
>> +POLICY_LOADPATH = /boot
>>
>> # policy source layout
>> POLDIR := policy
>> @@ -103,8 +103,8 @@ POLICY_SECTIONS += $(USERS) $(CONSTRAINTS) $(ISID_DEFS)
>> all: $(POLICY_FILENAME)
>>
>> install: $(POLICY_FILENAME)
>> - $(INSTALL_DIR) $(POLICY_LOADPATH)
>> - $(INSTALL_DATA) $^ $(POLICY_LOADPATH)
>> + $(INSTALL_DIR) $(DESTDIR)/$(POLICY_LOADPATH)
>> + $(INSTALL_DATA) $^ $(DESTDIR)/$(POLICY_LOADPATH)
>>
>> $(POLICY_FILENAME): policy.conf
>> $(CHECKPOLICY) $(CHECKPOLICY_PARAM) $^ -o $@
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-07-31 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 12:34 [Patch V3 1/3] Fixed flask policy's install path to avoid installing it as '/boot' file Vadim A. Misbakh-Soloviov
2013-07-30 12:34 ` [Patch V3 2/3] Fixed xen-tools makefile to build flask-tools and flask policy only if flask build especially enabled Vadim A. Misbakh-Soloviov
2013-07-30 12:34 ` [Patch V3 3/3] Fixed policy Makefile with Ian Campbell advice: Vadim A. Misbakh-Soloviov
2013-07-30 13:16 ` Ian Campbell
2013-07-30 14:36 ` Daniel De Graaf
2013-07-31 19:29 ` Vadim A. Misbakh-Soloviov [this message]
2013-07-31 19:43 ` Ian Campbell
2013-08-02 16:07 ` [Patch V3 1/3] Fixed flask policy's install path to avoid installing it as '/boot' file Ian Campbell
2013-08-02 17:10 ` Vadim A. Misbakh-Soloviov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F965A1.7090107@mva.name \
--to=mva@mva.name \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.