From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set
Date: Thu, 01 Aug 2013 09:54:02 +0300 [thread overview]
Message-ID: <51FA060A.2060202@linux.intel.com> (raw)
In-Reply-To: <1375326625-21427-1-git-send-email-amwang@redhat.com>
On 01/08/2013 06:10, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> When CONFIG_NET_LL_RX_POLL is not set, I got:
>
> net/socket.c: In function ‘sock_poll’:
> net/socket.c:1165:4: error: implicit declaration of function ‘sk_busy_loop’ [-Werror=implicit-function-declaration]
>
> Fix this by adding a nop when !CONFIG_NET_LL_RX_POLL.
>
Good catch!
There is a placeholder function, but it has a typo in the name.
With all the renaming I made a mistake and called the do-nothing
function sk_busy_poll while the implemented function is called sk_busy_loop.
so what we need is to rename sk_busy_loop() into sk_busy_poll.
(sorry I'm out of the office so I can't do much more than look at the
code at the moment.)
Thanks,
Eliezer
next prev parent reply other threads:[~2013-08-01 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 3:10 [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Cong Wang
2013-08-01 3:10 ` [Patch v2 net-next 2/2] net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL Cong Wang
2013-08-01 22:12 ` David Miller
2013-08-01 6:54 ` Eliezer Tamir [this message]
2013-08-01 8:08 ` [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Cong Wang
2013-08-01 20:03 ` David Miller
2013-08-02 3:04 ` Eliezer Tamir
2013-08-02 5:51 ` David Miller
2013-08-01 7:18 ` David Miller
2013-08-01 7:29 ` Eliezer Tamir
2013-08-01 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA060A.2060202@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.