From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: amwang@redhat.com, netdev@vger.kernel.org
Subject: Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set
Date: Thu, 01 Aug 2013 10:29:52 +0300 [thread overview]
Message-ID: <51FA0E70.6080408@linux.intel.com> (raw)
In-Reply-To: <20130801.001803.72283212544630263.davem@davemloft.net>
On 01/08/2013 10:18, David Miller wrote:
>> net/socket.c: In function ‘sock_poll’:
>> net/socket.c:1165:4: error: implicit declaration of function ‘sk_busy_loop’ [-Werror=implicit-function-declaration]
>>
>> Fix this by adding a nop when !CONFIG_NET_LL_RX_POLL.
>>
>> Cc: Eliezer Tamir <eliezer.tamir@linux.intel.com>
>> Cc: David S. Miller <davem@davemloft.net>
>> Signed-off-by: Cong Wang <amwang@redhat.com>
>
> Is this really a net-next specific problem? Doesn't it happen in
> 'net' too?
>
> If so, it should be fixed in 'net', not just 'net-next'.
Both issues are present in net.
And since these are bug fixes, IMHO both patches should go to net.
next prev parent reply other threads:[~2013-08-01 7:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 3:10 [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Cong Wang
2013-08-01 3:10 ` [Patch v2 net-next 2/2] net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL Cong Wang
2013-08-01 22:12 ` David Miller
2013-08-01 6:54 ` [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Eliezer Tamir
2013-08-01 8:08 ` Cong Wang
2013-08-01 20:03 ` David Miller
2013-08-02 3:04 ` Eliezer Tamir
2013-08-02 5:51 ` David Miller
2013-08-01 7:18 ` David Miller
2013-08-01 7:29 ` Eliezer Tamir [this message]
2013-08-01 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA0E70.6080408@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.