* [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_get_clusters
@ 2013-08-01 9:14 Joseph Qi
2013-08-01 9:25 ` Jeff Liu
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Qi @ 2013-08-01 9:14 UTC (permalink / raw)
To: ocfs2-devel
In ocfs2_attach_refcount_tree() and ocfs2_duplicate_extent_list(), if
error occurs when calling ocfs2_get_clusters(), it will go with
unexpected behavior as local variables p_cluster, num_clusters and
ext_flags are declared without initialization.
Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
---
fs/ocfs2/refcounttree.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
index 998b17e..3589ec1 100644
--- a/fs/ocfs2/refcounttree.c
+++ b/fs/ocfs2/refcounttree.c
@@ -3886,6 +3886,10 @@ static int ocfs2_attach_refcount_tree(struct
inode *inode,
while (cpos < clusters) {
ret = ocfs2_get_clusters(inode, cpos, &p_cluster,
&num_clusters, &ext_flags);
+ if (ret) {
+ mlog_errno(ret);
+ goto unlock;
+ }
if (p_cluster && !(ext_flags & OCFS2_EXT_REFCOUNTED)) {
ret = ocfs2_add_refcount_flag(inode, &di_et,
@@ -4057,6 +4061,10 @@ static int ocfs2_duplicate_extent_list(struct
inode *s_inode,
while (cpos < clusters) {
ret = ocfs2_get_clusters(s_inode, cpos, &p_cluster,
&num_clusters, &ext_flags);
+ if (ret) {
+ mlog_errno(ret);
+ goto out;
+ }
if (p_cluster) {
ret = ocfs2_add_refcounted_extent(t_inode, &et,
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_get_clusters
2013-08-01 9:14 [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_get_clusters Joseph Qi
@ 2013-08-01 9:25 ` Jeff Liu
2013-08-01 9:30 ` Joseph Qi
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Liu @ 2013-08-01 9:25 UTC (permalink / raw)
To: ocfs2-devel
On 08/01/2013 05:14 PM, Joseph Qi wrote:
> In ocfs2_attach_refcount_tree() and ocfs2_duplicate_extent_list(), if
> error occurs when calling ocfs2_get_clusters(), it will go with
> unexpected behavior as local variables p_cluster, num_clusters and
> ext_flags are declared without initialization.
>
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
> ---
> fs/ocfs2/refcounttree.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index 998b17e..3589ec1 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -3886,6 +3886,10 @@ static int ocfs2_attach_refcount_tree(struct
> inode *inode,
Line wrapped?
> while (cpos < clusters) {
> ret = ocfs2_get_clusters(inode, cpos, &p_cluster,
> &num_clusters, &ext_flags);
> + if (ret) {
> + mlog_errno(ret);
> + goto unlock;
> + }
>
> if (p_cluster && !(ext_flags & OCFS2_EXT_REFCOUNTED)) {
> ret = ocfs2_add_refcount_flag(inode, &di_et,
> @@ -4057,6 +4061,10 @@ static int ocfs2_duplicate_extent_list(struct
> inode *s_inode,
> while (cpos < clusters) {
> ret = ocfs2_get_clusters(s_inode, cpos, &p_cluster,
> &num_clusters, &ext_flags);
> + if (ret) {
> + mlog_errno(ret);
> + goto out;
> + }
>
> if (p_cluster) {
> ret = ocfs2_add_refcounted_extent(t_inode, &et,
^ permalink raw reply [flat|nested] 3+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_get_clusters
2013-08-01 9:25 ` Jeff Liu
@ 2013-08-01 9:30 ` Joseph Qi
0 siblings, 0 replies; 3+ messages in thread
From: Joseph Qi @ 2013-08-01 9:30 UTC (permalink / raw)
To: ocfs2-devel
On 2013/8/1 17:25, Jeff Liu wrote:
> On 08/01/2013 05:14 PM, Joseph Qi wrote:
>
>> In ocfs2_attach_refcount_tree() and ocfs2_duplicate_extent_list(), if
>> error occurs when calling ocfs2_get_clusters(), it will go with
>> unexpected behavior as local variables p_cluster, num_clusters and
>> ext_flags are declared without initialization.
>>
>> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
>> ---
>> fs/ocfs2/refcounttree.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
>> index 998b17e..3589ec1 100644
>> --- a/fs/ocfs2/refcounttree.c
>> +++ b/fs/ocfs2/refcounttree.c
>> @@ -3886,6 +3886,10 @@ static int ocfs2_attach_refcount_tree(struct
>> inode *inode,
>
> Line wrapped?
>
>> while (cpos < clusters) {
>> ret = ocfs2_get_clusters(inode, cpos, &p_cluster,
>> &num_clusters, &ext_flags);
>> + if (ret) {
>> + mlog_errno(ret);
>> + goto unlock;
>> + }
>>
>> if (p_cluster && !(ext_flags & OCFS2_EXT_REFCOUNTED)) {
>> ret = ocfs2_add_refcount_flag(inode, &di_et,
>> @@ -4057,6 +4061,10 @@ static int ocfs2_duplicate_extent_list(struct
>> inode *s_inode,
>> while (cpos < clusters) {
>> ret = ocfs2_get_clusters(s_inode, cpos, &p_cluster,
>> &num_clusters, &ext_flags);
>> + if (ret) {
>> + mlog_errno(ret);
>> + goto out;
>> + }
>>
>> if (p_cluster) {
>> ret = ocfs2_add_refcounted_extent(t_inode, &et,
>
>
>
Sorry, I will resend it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-01 9:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-01 9:14 [Ocfs2-devel] [PATCH] ocfs2: add the missing return value check of ocfs2_get_clusters Joseph Qi
2013-08-01 9:25 ` Jeff Liu
2013-08-01 9:30 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.