From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, rnayak@ti.com, benoit.cousson@linaro.org,
balbi@ti.com, george.cherian@ti.com, kishon@ti.com,
dmurphy@ti.com, t-kristo@ti.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] CLK: ti: dra7: Initialize USB_DPLL
Date: Thu, 1 Aug 2013 10:06:30 -0500 [thread overview]
Message-ID: <51FA7976.8020707@ti.com> (raw)
In-Reply-To: <1375369134-26398-2-git-send-email-rogerq@ti.com>
On 08/01/2013 09:58 AM, Roger Quadros wrote:
> USB_DPLL must be initialized and locked at boot so that
> USB modules can work.
>
> Also program USB_DLL_M2 output to half rate.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/clk/omap/clk-7xx.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clk/omap/clk-7xx.c b/drivers/clk/omap/clk-7xx.c
> index ddb39dd..f444513 100644
> --- a/drivers/clk/omap/clk-7xx.c
> +++ b/drivers/clk/omap/clk-7xx.c
> @@ -19,6 +19,7 @@
>
> #define DRA7_DPLL_ABE_DEFFREQ 361267200
> #define DRA7_DPLL_GMAC_DEFFREQ 1000000000
> +#define DRA7_DPLL_USB_DEFFREQ 960000000
>
>
> static struct omap_dt_clk dra7xx_clks[] = {
> @@ -63,5 +64,15 @@ int __init dra7xx_clk_init(void)
> if (rc)
> pr_err("%s: failed to configure GMAC DPLL!\n", __func__);
>
> + dpll_ck = clk_get_sys(NULL, "dpll_usb_ck");
> + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ);
> + if (rc)
> + pr_err("%s: failed to configure USB DPLL!\n", __func__);
> +
> + dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck");
> + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2);
> + if (rc)
> + pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__);
> +
> return rc;
> }
>
As I had mentioned on [1] - we are going to see similar needs keep
popping up. there is no need to hack this up for even more peripherals :(
http://marc.info/?l=linux-omap&m=137536803106017&w=2
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <tony@atomide.com>, <rnayak@ti.com>, <benoit.cousson@linaro.org>,
<balbi@ti.com>, <george.cherian@ti.com>, <kishon@ti.com>,
<dmurphy@ti.com>, <t-kristo@ti.com>, <linux-omap@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] CLK: ti: dra7: Initialize USB_DPLL
Date: Thu, 1 Aug 2013 10:06:30 -0500 [thread overview]
Message-ID: <51FA7976.8020707@ti.com> (raw)
In-Reply-To: <1375369134-26398-2-git-send-email-rogerq@ti.com>
On 08/01/2013 09:58 AM, Roger Quadros wrote:
> USB_DPLL must be initialized and locked at boot so that
> USB modules can work.
>
> Also program USB_DLL_M2 output to half rate.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/clk/omap/clk-7xx.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clk/omap/clk-7xx.c b/drivers/clk/omap/clk-7xx.c
> index ddb39dd..f444513 100644
> --- a/drivers/clk/omap/clk-7xx.c
> +++ b/drivers/clk/omap/clk-7xx.c
> @@ -19,6 +19,7 @@
>
> #define DRA7_DPLL_ABE_DEFFREQ 361267200
> #define DRA7_DPLL_GMAC_DEFFREQ 1000000000
> +#define DRA7_DPLL_USB_DEFFREQ 960000000
>
>
> static struct omap_dt_clk dra7xx_clks[] = {
> @@ -63,5 +64,15 @@ int __init dra7xx_clk_init(void)
> if (rc)
> pr_err("%s: failed to configure GMAC DPLL!\n", __func__);
>
> + dpll_ck = clk_get_sys(NULL, "dpll_usb_ck");
> + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ);
> + if (rc)
> + pr_err("%s: failed to configure USB DPLL!\n", __func__);
> +
> + dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck");
> + rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2);
> + if (rc)
> + pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__);
> +
> return rc;
> }
>
As I had mentioned on [1] - we are going to see similar needs keep
popping up. there is no need to hack this up for even more peripherals :(
http://marc.info/?l=linux-omap&m=137536803106017&w=2
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-08-01 15:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 14:58 [PATCH 0/4] ARM: DRA7-evm: USB host adaptation Roger Quadros
2013-08-01 14:58 ` Roger Quadros
2013-08-01 14:58 ` [PATCH 1/4] CLK: ti: dra7: Initialize USB_DPLL Roger Quadros
2013-08-01 14:58 ` Roger Quadros
2013-08-01 15:06 ` Nishanth Menon [this message]
2013-08-01 15:06 ` Nishanth Menon
2013-08-02 7:30 ` Roger Quadros
2013-08-02 7:30 ` Roger Quadros
2013-08-02 10:57 ` Tero Kristo
2013-08-02 10:57 ` Tero Kristo
2013-08-02 12:52 ` Nishanth Menon
2013-08-02 12:52 ` Nishanth Menon
2013-08-01 14:58 ` [PATCH 2/4] ARM: dts: dra7: Add USB related nodes Roger Quadros
2013-08-01 14:58 ` Roger Quadros
2013-08-02 15:02 ` George Cherian
2013-08-02 15:02 ` George Cherian
2013-08-05 7:52 ` Roger Quadros
2013-08-05 7:52 ` Roger Quadros
2013-08-01 14:58 ` [PATCH 3/4] dts: dra7-evm: add USB support Roger Quadros
2013-08-01 14:58 ` Roger Quadros
2013-08-02 15:04 ` George Cherian
2013-08-02 15:04 ` George Cherian
2013-08-05 7:55 ` Roger Quadros
2013-08-05 7:55 ` Roger Quadros
2013-08-05 9:03 ` George Cherian
2013-08-05 9:03 ` George Cherian
2013-08-05 10:23 ` Roger Quadros
2013-08-05 10:23 ` Roger Quadros
2013-08-01 14:58 ` [PATCH 4/4] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
2013-08-01 14:58 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA7976.8020707@ti.com \
--to=nm@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.