From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework
Date: Thu, 01 Aug 2013 21:30:08 +0400 [thread overview]
Message-ID: <51FA9B20.3080304@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1308011153180.1534-100000@iolanthe.rowland.org>
Hello.
On 08/01/2013 07:56 PM, Alan Stern wrote:
>>> What happens if uclk isn't found but it is needed?
>> It will not fail but I guess the usb host won't work as the clock won't
>> be correctly
>> configured.
>> I agree with you: this is not a good solution.
>> Another option is to keep the previous version of this patch and put
>> uclk handling
>> in "#ifdef CONFIG_COMMON_CLK #endif" sections.
>> Would this be acceptable ?
> Yes. However, a more elegant approach is to protect the relevant
> statements with: if (defined(CONFIG_COMMON_CLK)). This preprocessor
You probably meant IS_ENABLED() or IS_BUIILTIN()? Or is there something I
don't know about gcc preprocessor?
> evaluates this to a 0 or 1, so the compiler will not generate output
> for the protected source code if the symbol isn't defined.
> Alan Stern
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: boris brezillon <b.brezillon@overkiz.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework
Date: Thu, 01 Aug 2013 21:30:08 +0400 [thread overview]
Message-ID: <51FA9B20.3080304@cogentembedded.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1308011153180.1534-100000@iolanthe.rowland.org>
Hello.
On 08/01/2013 07:56 PM, Alan Stern wrote:
>>> What happens if uclk isn't found but it is needed?
>> It will not fail but I guess the usb host won't work as the clock won't
>> be correctly
>> configured.
>> I agree with you: this is not a good solution.
>> Another option is to keep the previous version of this patch and put
>> uclk handling
>> in "#ifdef CONFIG_COMMON_CLK #endif" sections.
>> Would this be acceptable ?
> Yes. However, a more elegant approach is to protect the relevant
> statements with: if (defined(CONFIG_COMMON_CLK)). This preprocessor
You probably meant IS_ENABLED() or IS_BUIILTIN()? Or is there something I
don't know about gcc preprocessor?
> evaluates this to a 0 or 1, so the compiler will not generate output
> for the protected source code if the symbol isn't defined.
> Alan Stern
WBR, Sergei
next prev parent reply other threads:[~2013-08-01 17:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 6:16 [PATCH] USB: ohci-at91: add usb_clk for transition to common clk framework Boris BREZILLON
2013-08-01 6:16 ` Boris BREZILLON
2013-08-01 14:39 ` Alan Stern
2013-08-01 14:39 ` Alan Stern
2013-08-01 15:14 ` boris brezillon
2013-08-01 15:14 ` boris brezillon
2013-08-01 15:56 ` Alan Stern
2013-08-01 15:56 ` Alan Stern
2013-08-01 17:30 ` Sergei Shtylyov [this message]
2013-08-01 17:30 ` Sergei Shtylyov
2013-08-01 17:38 ` Alan Stern
2013-08-01 17:38 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FA9B20.3080304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.