All of lore.kernel.org
 help / color / mirror / Atom feed
From: "\"“tiejun.chen”\"" <tiejun.chen@windriver.com>
To: Bharat Bhushan <r65777@freescale.com>
Cc: benh@kernel.crashing.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
	kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	scottwood@freescale.com,
	Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control "G" attribute in mas2
Date: Fri, 02 Aug 2013 06:39:59 +0000	[thread overview]
Message-ID: <51FB543F.1010402@windriver.com> (raw)
In-Reply-To: <1375355558-19187-4-git-send-email-Bharat.Bhushan@freescale.com>

On 08/01/2013 07:12 PM, Bharat Bhushan wrote:
> "G" bit in MAS2 indicates whether the page is Guarded.
> There is no reason to stop guest setting  "E", so allow him.

Could we merge patch 2 and 3 into only one.

Tiejun

>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
> ---
> v1->v2
>   - no change
>
>   arch/powerpc/kvm/e500.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kvm/e500.h b/arch/powerpc/kvm/e500.h
> index 277cb18..4fd9650 100644
> --- a/arch/powerpc/kvm/e500.h
> +++ b/arch/powerpc/kvm/e500.h
> @@ -117,7 +117,7 @@ static inline struct kvmppc_vcpu_e500 *to_e500(struct kvm_vcpu *vcpu)
>   #define E500_TLB_USER_PERM_MASK (MAS3_UX|MAS3_UR|MAS3_UW)
>   #define E500_TLB_SUPER_PERM_MASK (MAS3_SX|MAS3_SR|MAS3_SW)
>   #define MAS2_ATTRIB_MASK \
> -	  (MAS2_X0 | MAS2_X1 | MAS2_E)
> +	  (MAS2_X0 | MAS2_X1 | MAS2_E | MAS2_G)
>   #define MAS3_ATTRIB_MASK \
>   	  (MAS3_U0 | MAS3_U1 | MAS3_U2 | MAS3_U3 \
>   	   | E500_TLB_USER_PERM_MASK | E500_TLB_SUPER_PERM_MASK)
>


WARNING: multiple messages have this Message-ID (diff)
From: "\"“tiejun.chen”\"" <tiejun.chen@windriver.com>
To: Bharat Bhushan <r65777@freescale.com>
Cc: kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
	Bharat Bhushan <Bharat.Bhushan@freescale.com>,
	scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control "G" attribute in mas2
Date: Fri, 2 Aug 2013 14:39:59 +0800	[thread overview]
Message-ID: <51FB543F.1010402@windriver.com> (raw)
In-Reply-To: <1375355558-19187-4-git-send-email-Bharat.Bhushan@freescale.com>

On 08/01/2013 07:12 PM, Bharat Bhushan wrote:
> "G" bit in MAS2 indicates whether the page is Guarded.
> There is no reason to stop guest setting  "E", so allow him.

Could we merge patch 2 and 3 into only one.

Tiejun

>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
> ---
> v1->v2
>   - no change
>
>   arch/powerpc/kvm/e500.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kvm/e500.h b/arch/powerpc/kvm/e500.h
> index 277cb18..4fd9650 100644
> --- a/arch/powerpc/kvm/e500.h
> +++ b/arch/powerpc/kvm/e500.h
> @@ -117,7 +117,7 @@ static inline struct kvmppc_vcpu_e500 *to_e500(struct kvm_vcpu *vcpu)
>   #define E500_TLB_USER_PERM_MASK (MAS3_UX|MAS3_UR|MAS3_UW)
>   #define E500_TLB_SUPER_PERM_MASK (MAS3_SX|MAS3_SR|MAS3_SW)
>   #define MAS2_ATTRIB_MASK \
> -	  (MAS2_X0 | MAS2_X1 | MAS2_E)
> +	  (MAS2_X0 | MAS2_X1 | MAS2_E | MAS2_G)
>   #define MAS3_ATTRIB_MASK \
>   	  (MAS3_U0 | MAS3_U1 | MAS3_U2 | MAS3_U3 \
>   	   | E500_TLB_USER_PERM_MASK | E500_TLB_SUPER_PERM_MASK)
>

WARNING: multiple messages have this Message-ID (diff)
From: "\"“tiejun.chen”\"" <tiejun.chen@windriver.com>
To: Bharat Bhushan <r65777@freescale.com>
Cc: <benh@kernel.crashing.org>, <agraf@suse.de>,
	<kvm-ppc@vger.kernel.org>, <kvm@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, <scottwood@freescale.com>,
	Bharat Bhushan <Bharat.Bhushan@freescale.com>
Subject: Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control "G" attribute in mas2
Date: Fri, 2 Aug 2013 14:39:59 +0800	[thread overview]
Message-ID: <51FB543F.1010402@windriver.com> (raw)
In-Reply-To: <1375355558-19187-4-git-send-email-Bharat.Bhushan@freescale.com>

On 08/01/2013 07:12 PM, Bharat Bhushan wrote:
> "G" bit in MAS2 indicates whether the page is Guarded.
> There is no reason to stop guest setting  "E", so allow him.

Could we merge patch 2 and 3 into only one.

Tiejun

>
> Signed-off-by: Bharat Bhushan <bharat.bhushan@freescale.com>
> ---
> v1->v2
>   - no change
>
>   arch/powerpc/kvm/e500.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kvm/e500.h b/arch/powerpc/kvm/e500.h
> index 277cb18..4fd9650 100644
> --- a/arch/powerpc/kvm/e500.h
> +++ b/arch/powerpc/kvm/e500.h
> @@ -117,7 +117,7 @@ static inline struct kvmppc_vcpu_e500 *to_e500(struct kvm_vcpu *vcpu)
>   #define E500_TLB_USER_PERM_MASK (MAS3_UX|MAS3_UR|MAS3_UW)
>   #define E500_TLB_SUPER_PERM_MASK (MAS3_SX|MAS3_SR|MAS3_SW)
>   #define MAS2_ATTRIB_MASK \
> -	  (MAS2_X0 | MAS2_X1 | MAS2_E)
> +	  (MAS2_X0 | MAS2_X1 | MAS2_E | MAS2_G)
>   #define MAS3_ATTRIB_MASK \
>   	  (MAS3_U0 | MAS3_U1 | MAS3_U2 | MAS3_U3 \
>   	   | E500_TLB_USER_PERM_MASK | E500_TLB_SUPER_PERM_MASK)
>

  reply	other threads:[~2013-08-02  6:39 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 11:12 [PATCH 0/6 v2] kvm: powerpc: use cache attributes from linux pte Bharat Bhushan
2013-08-01 11:24 ` Bharat Bhushan
2013-08-01 11:12 ` [PATCH 1/6 v2] powerpc: book3e: _PAGE_LENDIAN must be _PAGE_ENDIAN Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-01 11:12 ` [PATCH 2/6 v2] kvm: powerpc: allow guest control "E" attribute in mas2 Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-01 11:12 ` [PATCH 3/6 v2] kvm: powerpc: allow guest control "G" " Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-02  6:39   ` "“tiejun.chen”" [this message]
2013-08-02  6:39     ` "“tiejun.chen”"
2013-08-02  6:39     ` "“tiejun.chen”"
2013-08-01 11:12 ` [PATCH 4/6 v2] powerpc: move linux pte/hugepte search to more generic file Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-01 11:12 ` [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-02  6:37   ` "“tiejun.chen”"
2013-08-02  6:37     ` "“tiejun.chen”"
2013-08-02  6:37     ` "“tiejun.chen”"
2013-08-02 22:58   ` Scott Wood
2013-08-02 22:58     ` Scott Wood
2013-08-02 22:58     ` Scott Wood
2013-08-02 23:16     ` Benjamin Herrenschmidt
2013-08-02 23:16       ` Benjamin Herrenschmidt
2013-08-02 23:16       ` Benjamin Herrenschmidt
2013-08-03  2:58       ` Bhushan Bharat-R65777
2013-08-03  2:58         ` Bhushan Bharat-R65777
2013-08-03  2:58         ` Bhushan Bharat-R65777
2013-08-03  4:24         ` Benjamin Herrenschmidt
2013-08-03  4:24           ` Benjamin Herrenschmidt
2013-08-03  4:24           ` Benjamin Herrenschmidt
2013-08-05 14:27           ` Bhushan Bharat-R65777
2013-08-05 14:27             ` Bhushan Bharat-R65777
2013-08-05 14:27             ` Bhushan Bharat-R65777
2013-08-05 19:19             ` Scott Wood
2013-08-05 19:19               ` Scott Wood
2013-08-05 19:19               ` Scott Wood
2013-08-06  1:12               ` Bhushan Bharat-R65777
2013-08-06  1:12                 ` Bhushan Bharat-R65777
2013-08-06  1:12                 ` Bhushan Bharat-R65777
2013-08-06  7:02               ` Bhushan Bharat-R65777
2013-08-06  7:02                 ` Bhushan Bharat-R65777
2013-08-06  7:02                 ` Bhushan Bharat-R65777
2013-08-07  0:24                 ` Paul Mackerras
2013-08-07  0:24                   ` Paul Mackerras
2013-08-07  0:24                   ` Paul Mackerras
2013-08-07  1:11                   ` Scott Wood
2013-08-07  1:11                     ` Scott Wood
2013-08-07  1:11                     ` Scott Wood
2013-08-07  1:47                     ` Paul Mackerras
2013-08-07  1:47                       ` Paul Mackerras
2013-08-07  1:47                       ` Paul Mackerras
2013-08-06 14:46               ` Bhushan Bharat-R65777
2013-08-06 14:46                 ` Bhushan Bharat-R65777
2013-08-06 14:46                 ` Bhushan Bharat-R65777
2013-08-01 11:12 ` [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte Bharat Bhushan
2013-08-01 11:24   ` Bharat Bhushan
2013-08-01 11:12   ` Bharat Bhushan
2013-08-02  6:24   ` "“tiejun.chen”"
2013-08-02  6:24     ` "“tiejun.chen”"
2013-08-02  6:24     ` "“tiejun.chen”"
2013-08-02 23:34   ` Scott Wood
2013-08-02 23:34     ` Scott Wood
2013-08-02 23:34     ` Scott Wood
2013-08-03  3:11     ` Bhushan Bharat-R65777
2013-08-03  3:11       ` Bhushan Bharat-R65777
2013-08-03  3:11       ` Bhushan Bharat-R65777
2013-08-03  4:25       ` Benjamin Herrenschmidt
2013-08-03  4:25         ` Benjamin Herrenschmidt
2013-08-03  4:25         ` Benjamin Herrenschmidt
2013-08-05 16:28         ` Scott Wood
2013-08-05 16:28           ` Scott Wood
2013-08-05 16:28           ` Scott Wood
2013-08-05 16:30       ` Scott Wood
2013-08-05 16:30         ` Scott Wood
2013-08-05 16:30         ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FB543F.1010402@windriver.com \
    --to=tiejun.chen@windriver.com \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=r65777@freescale.com \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.