All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, libvir-list@redhat.com,
	hutao@cn.fujitsu.com, marcel.a@redhat.com, qemu-devel@nongnu.org,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device
Date: Fri, 02 Aug 2013 10:31:11 +0200	[thread overview]
Message-ID: <51FB6E4F.4010107@redhat.com> (raw)
In-Reply-To: <51FAE445.3020607@redhat.com>

On 08/02/2013 12:42 AM, Eric Blake wrote:
> On 08/01/2013 04:23 PM, Paolo Bonzini wrote:
>>> Automatic devices with no command line argument have proven to be a
>>> nightmare for libvirt as well.  Although the just-released libvirt 1.1.1
>>> now supports the <on_crash> element for controlling the command line
>>> parameters of qemu related to how qemu will behave when the pvpanic
>>> device is triggered, I would also welcome having the ability to control
>>> whether the guest even has a pvpanic device exposed, just as we can
>>> control whether a guest has a memballoon device exposed.
>>
>> This is quite different from memballoon.
>>
>> pvpanic is a single I/O port, it doesn't use up a PCI slot (thus
>> causing conflicts with other devices at the same address).
>>
>> Perhaps this issue is simply fixed by making the _STA method
>> return 0x0B instead of 0x0F (i.e. turning off the "show in user
>> interface" bit).
>
> That may "fix" the issue of a windows guest showing the yellow ! mark,
> but what if, down the road, someone writes an actual windows driver that
> is aware of that port and how to make a windows BSOD write a panic
> notification to the port?  How does a user go about installing such a
> driver if the device is not exposed in the user interface list of devices?

The user can still manually install a driver even for a device that is 
not exposed.

Having to manually specify the pvpanic device would be yet another knob 
that nobody uses.  Panic notification is a useful feature that should be 
supported with no particular intervention from the user.

Paolo

  reply	other threads:[~2013-08-02  8:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 13:08 [Qemu-devel] pvpanic device should not be automatically included as an internal device Marcel Apfelbaum
2013-08-01 13:32 ` Michael S. Tsirkin
2013-08-01 16:39   ` Marcel Apfelbaum
2013-08-01 14:18 ` Gerd Hoffmann
2013-08-01 16:26   ` Eric Blake
2013-08-01 16:31     ` Michael S. Tsirkin
2013-08-01 16:41       ` Marcel Apfelbaum
2013-08-01 22:23     ` Paolo Bonzini
2013-08-01 22:42       ` Eric Blake
2013-08-02  8:31         ` Paolo Bonzini [this message]
2013-08-02  9:24           ` Daniel P. Berrange
2013-08-02  7:04 ` [Qemu-devel] [PATCH for-1.6 1/2] don't create pvpanic device by default Hu Tao
2013-08-02  8:27   ` Paolo Bonzini
2013-08-11 10:33     ` Michael S. Tsirkin
2013-08-11 14:45       ` Andreas Färber
2013-08-11 15:12         ` Michael S. Tsirkin
2013-08-11 15:16         ` Marcel Apfelbaum
2013-08-02  7:04 ` [Qemu-devel] [PATCH for-1.6 2/2] pvpanic: make pvpanic known to user Hu Tao
2013-08-02 12:20   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FB6E4F.4010107@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=eblake@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=kraxel@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.