From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
Sakari Ailus <sakari.ailus@iki.fi>,
Katsuya MATSUBARA <matsu@igel.co.jp>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH v5 1/9] media: Add support for circular graph traversal
Date: Fri, 02 Aug 2013 09:44:34 +0000 [thread overview]
Message-ID: <51FB7F82.5070500@xs4all.nl> (raw)
In-Reply-To: <1375405408-17134-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
> The graph traversal API (media_entity_graph_walk_*) doesn't support
> cyclic graphs and will fail to correctly walk a graph when circular
> links exist. Support circular graph traversal by checking whether an
> entity has already been visited before pushing it to the stack.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
Sakari Ailus <sakari.ailus@iki.fi>,
Katsuya MATSUBARA <matsu@igel.co.jp>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Subject: Re: [PATCH v5 1/9] media: Add support for circular graph traversal
Date: Fri, 02 Aug 2013 11:44:34 +0200 [thread overview]
Message-ID: <51FB7F82.5070500@xs4all.nl> (raw)
In-Reply-To: <1375405408-17134-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 08/02/2013 03:03 AM, Laurent Pinchart wrote:
> The graph traversal API (media_entity_graph_walk_*) doesn't support
> cyclic graphs and will fail to correctly walk a graph when circular
> links exist. Support circular graph traversal by checking whether an
> entity has already been visited before pushing it to the stack.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
next prev parent reply other threads:[~2013-08-02 9:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 1:03 [PATCH v5 0/9] Renesas VSP1 driver Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 1:03 ` [PATCH v5 1/9] media: Add support for circular graph traversal Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:44 ` Hans Verkuil [this message]
2013-08-02 9:44 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 2/9] Documentation: media: Clarify the VIDIOC_CREATE_BUFS format requirements Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:43 ` Hans Verkuil
2013-08-02 9:43 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 3/9] videobuf2: Clarify queue_setup() and buf_prepare() usage documentation Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:45 ` Hans Verkuil
2013-08-02 9:45 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 4/9] v4l: Fix V4L2_MBUS_FMT_YUV10_1X30 media bus pixel code value Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:45 ` Hans Verkuil
2013-08-02 9:45 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 5/9] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:47 ` Hans Verkuil
2013-08-02 9:47 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 6/9] v4l: Add V4L2_PIX_FMT_NV16M and V4L2_PIX_FMT_NV61M formats Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:54 ` Hans Verkuil
2013-08-02 9:54 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 7/9] v4l: Renesas R-Car VSP1 driver Laurent Pinchart
2013-08-02 9:23 ` Hans Verkuil
2013-08-02 9:23 ` Hans Verkuil
2013-08-02 10:57 ` Laurent Pinchart
2013-08-02 10:57 ` Laurent Pinchart
2013-08-02 11:14 ` Hans Verkuil
2013-08-02 11:14 ` Hans Verkuil
2013-08-02 11:16 ` Laurent Pinchart
2013-08-02 11:16 ` Laurent Pinchart
2013-08-02 1:03 ` [PATCH v5 8/9] vsp1: Fix lack of the sink entity registration for enabled links Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:55 ` Hans Verkuil
2013-08-02 9:55 ` Hans Verkuil
2013-08-02 1:03 ` [PATCH v5 9/9] vsp1: Use the maximum number of entities defined in platform data Laurent Pinchart
2013-08-02 1:03 ` Laurent Pinchart
2013-08-02 9:55 ` Hans Verkuil
2013-08-02 9:55 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB7F82.5070500@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=matsu@igel.co.jp \
--cc=sakari.ailus@iki.fi \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.