From: Tuomas Tynkkynen <ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: "balbi-l0cyMroinI0@public.gmane.org"
<balbi-l0cyMroinI0@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org"
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Subject: Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters
Date: Fri, 2 Aug 2013 17:15:39 +0300 [thread overview]
Message-ID: <51FBBF0B.5020908@nvidia.com> (raw)
In-Reply-To: <51FACE74.3070909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 08/02/2013 12:09 AM, Stephen Warren wrote:
> On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote:
>> Some of the PHY parameters are not set according to the TRMs:
>>
>> - UTMIP_FS_PREABMLE_J should be set, not cleared
>> - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set
>> - UTMIP_PD_CHRG should be set in host mode and cleared in device mode
>> - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set
>
>> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
>
>> #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0)
>> +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22)
>
> You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm
> pretty sure I mentioned this in downstream review. Perhaps check my
> review comments to see if anything else was missed?
>
Well in my opinion that increases the risk of typoing the mask.
I'll fix along with the other things.
WARNING: multiple messages have this Message-ID (diff)
From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "balbi@ti.com" <balbi@ti.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters
Date: Fri, 2 Aug 2013 17:15:39 +0300 [thread overview]
Message-ID: <51FBBF0B.5020908@nvidia.com> (raw)
In-Reply-To: <51FACE74.3070909@wwwdotorg.org>
On 08/02/2013 12:09 AM, Stephen Warren wrote:
> On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote:
>> Some of the PHY parameters are not set according to the TRMs:
>>
>> - UTMIP_FS_PREABMLE_J should be set, not cleared
>> - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set
>> - UTMIP_PD_CHRG should be set in host mode and cleared in device mode
>> - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set
>
>> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
>
>> #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0)
>> +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22)
>
> You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm
> pretty sure I mentioned this in downstream review. Perhaps check my
> review comments to see if anything else was missed?
>
Well in my opinion that increases the risk of typoing the mask.
I'll fix along with the other things.
next prev parent reply other threads:[~2013-08-02 14:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 17:41 [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Tuomas Tynkkynen
2013-07-31 17:41 ` Tuomas Tynkkynen
[not found] ` <1375292522-7855-1-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 17:41 ` [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit Tuomas Tynkkynen
2013-07-31 17:41 ` Tuomas Tynkkynen
[not found] ` <1375292522-7855-2-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-31 18:35 ` Alan Stern
2013-07-31 18:35 ` Alan Stern
2013-08-01 8:05 ` Matthieu CASTET
2013-08-02 15:42 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
[not found] ` <1375292522-7855-6-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-01 21:17 ` Stephen Warren
2013-08-01 21:17 ` Stephen Warren
2013-07-31 17:41 ` [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters Tuomas Tynkkynen
2013-07-31 17:41 ` Tuomas Tynkkynen
[not found] ` <1375292522-7855-3-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-01 21:09 ` Stephen Warren
2013-08-01 21:09 ` Stephen Warren
[not found] ` <51FACE74.3070909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-02 14:15 ` Tuomas Tynkkynen [this message]
2013-08-02 14:15 ` Tuomas Tynkkynen
2013-07-31 17:41 ` [PATCH 3/6] usb: phy: tegra: Tegra30 support Tuomas Tynkkynen
2013-07-31 17:41 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 4/6] usb: phy: tegra: Program new PHY parameters Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
2013-08-01 21:16 ` Stephen Warren
[not found] ` <51FAD020.8090306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-02 14:05 ` Tuomas Tynkkynen
2013-08-02 14:05 ` Tuomas Tynkkynen
2013-07-31 17:42 ` [PATCH 6/6] usb: host: tegra: Tegra30 support Tuomas Tynkkynen
2013-07-31 17:42 ` Tuomas Tynkkynen
[not found] ` <1375292522-7855-7-git-send-email-ttynkkynen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-01 21:18 ` Stephen Warren
2013-08-01 21:18 ` Stephen Warren
2013-07-31 23:22 ` [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support Stephen Warren
2013-08-01 13:02 ` Tuomas Tynkkynen
[not found] ` <51FA5C5A.2080900-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-01 16:22 ` Stephen Warren
2013-08-01 16:22 ` Stephen Warren
[not found] ` <51FA8B3B.8070504-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-02 7:52 ` Felipe Balbi
2013-08-02 7:52 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FBBF0B.5020908@nvidia.com \
--to=ttynkkynen-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.