From: ChenQi <Qi.Chen@windriver.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: poky@yoctoproject.org, Zhangle.Yang@windriver.com
Subject: Re: [PATCH 1/1] tiny-init: fix bashism
Date: Mon, 5 Aug 2013 09:28:06 +0800 [thread overview]
Message-ID: <51FEFFA6.9000502@windriver.com> (raw)
In-Reply-To: <1375452334.978.2.camel@dvhart-mobl1.amr.corp.intel.com>
On 08/02/2013 10:05 PM, Darren Hart wrote:
> On Fri, 2013-08-02 at 15:56 +0800, Qi.Chen@windriver.com wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
> I understand this is a simple fix, but please provide a commit log. In
> this case, something like the following would suffice:
>
> "source" is a bashism, replace it with the posix shell compliant "."
Thanks.
Comment added and V2 sent.
Best Regards,
Chen Qi
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
>
>
>> ---
>> meta-yocto/recipes-core/tiny-init/files/init | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-yocto/recipes-core/tiny-init/files/init b/meta-yocto/recipes-core/tiny-init/files/init
>> index 4b78f01..9140e95 100644
>> --- a/meta-yocto/recipes-core/tiny-init/files/init
>> +++ b/meta-yocto/recipes-core/tiny-init/files/init
>> @@ -15,7 +15,7 @@ ifup lo
>>
>> # Allow for distro or local customizations
>> if [ -f /etc/rc.local ] ; then
>> - source /etc/rc.local
>> + . /etc/rc.local
>> fi
>>
>> # Become session leader and try to find a real tty (e.g. ttyS0)
prev parent reply other threads:[~2013-08-05 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1375430111.git.Qi.Chen@windriver.com>
2013-08-02 7:56 ` [PATCH 1/1] tiny-init: fix bashism Qi.Chen
2013-08-02 14:05 ` Darren Hart
2013-08-05 1:28 ` ChenQi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FEFFA6.9000502@windriver.com \
--to=qi.chen@windriver.com \
--cc=Zhangle.Yang@windriver.com \
--cc=dvhart@linux.intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.